From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: shakeelb@google.com
Cc: minchan@kernel.org, ying.huang@intel.com,
mgorman@techsingularity.net, vdavydov.dev@gmail.com,
mhocko@kernel.org, gthelen@google.com, hannes@cmpxchg.org,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm, shrinker: make shrinker_list lockless
Date: Fri, 10 Nov 2017 06:46:19 +0900 [thread overview]
Message-ID: <201711100646.IJH39597.HOtMLJVSFOQFOF@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <CALvZod5NVQO+dWKD0y4pK-JYXdehLLgKm0bfc7ExPzyRLDeqzw@mail.gmail.com>
Shakeel Butt wrote:
> > If you can accept serialized register_shrinker()/unregister_shrinker(),
> > I think that something like shown below can do it.
>
> If we assume that we will never do register_shrinker and
> unregister_shrinker on the same object in parallel then do we still
> need to do msleep & synchronize_rcu() within mutex?
Doing register_shrinker() and unregister_shrinker() on the same object
in parallel is wrong. This mutex is to ensure that we do not need to
worry about ->list.next field. synchronize_rcu() should not be slow.
If you want to avoid msleep() with mutex held, you can also apply
> > If you want parallel register_shrinker()/unregister_shrinker(), something like
> > shown below on top of shown above will do it.
change.
next prev parent reply other threads:[~2017-11-09 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 17:37 [PATCH v2] mm, shrinker: make shrinker_list lockless Shakeel Butt
2017-11-08 17:58 ` Greg Thelen
2017-11-09 0:07 ` Minchan Kim
2017-11-09 1:07 ` Shakeel Butt
2017-11-09 1:40 ` Minchan Kim
2017-11-09 10:26 ` Tetsuo Handa
2017-11-09 15:34 ` Shakeel Butt
2017-11-09 21:46 ` Tetsuo Handa [this message]
2017-11-10 18:16 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711100646.IJH39597.HOtMLJVSFOQFOF@I-love.SAKURA.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=akpm@linux-foundation.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=shakeelb@google.com \
--cc=vdavydov.dev@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).