From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440AbdKJJVH (ORCPT ); Fri, 10 Nov 2017 04:21:07 -0500 Received: from merlin.infradead.org ([205.233.59.134]:48950 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbdKJJVE (ORCPT ); Fri, 10 Nov 2017 04:21:04 -0500 Date: Fri, 10 Nov 2017 10:20:46 +0100 From: Peter Zijlstra To: Alexei Starovoitov Cc: Josef Bacik , rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ast@kernel.org, kernel-team@fb.com, daniel@iogearbox.net Subject: Re: [PATCH 0/2][v5] Add the ability to do BPF directed error injection Message-ID: <20171110092046.2mfewtmt6gjzzjs7@hirez.programming.kicks-ass.net> References: <1510086523-8859-1-git-send-email-josef@toxicpanda.com> <04fd674a-6921-d2ea-8e89-856397ab297d@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <04fd674a-6921-d2ea-8e89-856397ab297d@fb.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 08, 2017 at 06:43:25AM +0900, Alexei Starovoitov wrote: > On 11/8/17 5:28 AM, Josef Bacik wrote: > > I'm sending this through Dave since it'll conflict with other BPF changes in his > > tree, but since it touches tracing as well Dave would like a review from > > somebody on the tracing side. > > > > v4->v5: > > - disallow kprobe_override programs from being put in the prog map array so we > > don't tail call into something we didn't check. This allows us to make the > > normal path still fast without a bunch of percpu operations. > > looks great to me. > Peter, > could you please review x86 bits? I did not in fact get the patch... But after digging it out of LKML I don't immediately see something broken, but this is not stuff I typically know well.