From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752948AbdKJOH0 (ORCPT ); Fri, 10 Nov 2017 09:07:26 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52142 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751558AbdKJOHZ (ORCPT ); Fri, 10 Nov 2017 09:07:25 -0500 Date: Fri, 10 Nov 2017 15:07:19 +0100 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling Message-ID: <20171110140719.GC11872@lunn.ch> References: <20171110115435.4261-1-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171110115435.4261-1-privat@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > skb->offload_fwd_mark calculation is a candidate for consolidation into the > DSA core. The calculation can probably be more polished when done at a point > where DSA has updated skb. Hi Egil Yes, at some point we should do this. But at the moment it is too early. We don't have enough experience with what the different switches need. I would like to see 4 or more devices doing it before we consolidate the code into the core. Andrew