From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753054AbdKJOKD (ORCPT ); Fri, 10 Nov 2017 09:10:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:52149 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbdKJOKC (ORCPT ); Fri, 10 Nov 2017 09:10:02 -0500 Date: Fri, 10 Nov 2017 15:10:00 +0100 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/2] net: dsa: lan9303: Set up trapping of IGMP to CPU port Message-ID: <20171110141000.GD11872@lunn.ch> References: <20171110115435.4261-1-privat@egil-hjelmeland.no> <20171110115435.4261-2-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171110115435.4261-2-privat@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 10, 2017 at 12:54:34PM +0100, Egil Hjelmeland wrote: > IGMP packets should be trapped to the CPU port. The SW bridge knows > whether to forward to other ports. > > With "IGMP snooping for local traffic" merged, IGMP trapping is also > required for stable IGMPv2 operation. > > LAN9303 does not trap IGMP packets by default. > > Enable IGMP trapping in lan9303_setup. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Andrew