From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbdKKGKu (ORCPT ); Sat, 11 Nov 2017 01:10:50 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43630 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750776AbdKKGKt (ORCPT ); Sat, 11 Nov 2017 01:10:49 -0500 Date: Sat, 11 Nov 2017 15:10:45 +0900 (KST) Message-Id: <20171111.151045.2265321498503747008.davem@davemloft.net> To: sam@mendozajonas.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/2] net/ncsi: Don't return error on normal response From: David Miller In-Reply-To: <20171108053045.1961-2-sam@mendozajonas.com> References: <20171108053045.1961-1-sam@mendozajonas.com> <20171108053045.1961-2-sam@mendozajonas.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Nov 2017 22:10:48 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:45 +1100 > Several response handlers return EBUSY if the data corresponding to the > command/response pair is already set. There is no reason to return an > error here; the channel is advertising something as enabled because we > told it to enable it, and it's possible that the feature has been > enabled previously. > > Signed-off-by: Samuel Mendoza-Jonas Applied.