From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbdKKKOA (ORCPT ); Sat, 11 Nov 2017 05:14:00 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751299AbdKKKN6 (ORCPT ); Sat, 11 Nov 2017 05:13:58 -0500 Date: Sat, 11 Nov 2017 19:13:54 +0900 (KST) Message-Id: <20171111.191354.1268716566266491493.davem@davemloft.net> To: colin.king@canonical.com Cc: harish.patil@cavium.com, manish.chopra@cavium.com, Dept-GELinuxNICDev@cavium.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] qlge: remove duplicated assignment to mbcp From: David Miller In-Reply-To: <20171109075215.2666-1-colin.king@canonical.com> References: <20171109075215.2666-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 11 Nov 2017 02:13:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Thu, 9 Nov 2017 07:52:15 +0000 > From: Colin Ian King > > The assignment to mbcp is identical to the initiatialized value assigned > to mbcp at declaration time a few lines earlier, hence we can remove the > second redundant assignment. Cleans up clang warning: > > drivers/net/ethernet/qlogic/qlge/qlge_mpi.c:209:22: warning: > Value stored to 'mbcp' during its initialization is never read > > Signed-off-by: Colin Ian King Applied, thanks.