From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754753AbdKKBnE (ORCPT ); Fri, 10 Nov 2017 20:43:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:60074 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbdKKBnC (ORCPT ); Fri, 10 Nov 2017 20:43:02 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 822AD60600 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org From: Stephen Boyd To: Heikki Krogerus , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Rob Clark , Peter Robinson Subject: [PATCH] usb: ulpi: Add missing of_node_get() in ulpi_of_register() Date: Fri, 10 Nov 2017 17:43:00 -0800 Message-Id: <20171111014300.2982-1-sboyd@codeaurora.org> X-Mailer: git-send-email 2.15.0.124.g7668cbc60578 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In ulpi_of_register() we call of_find_node_by_name() which unconditionally calls of_node_put() on the 'from' argument. We haven't called of_node_get() though, so we've put the node once without getting it first. Add the of_node_get() call so that things are properly balanced. Fixes: ef6a7bcfb01c ("usb: ulpi: Support device discovery via DT") Reported-by: Peter Robinson Signed-off-by: Stephen Boyd --- drivers/usb/common/ulpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c index 4aa5195db8ea..59e05eff76f9 100644 --- a/drivers/usb/common/ulpi.c +++ b/drivers/usb/common/ulpi.c @@ -182,9 +182,9 @@ static int ulpi_of_register(struct ulpi *ulpi) /* Find a ulpi bus underneath the parent or the grandparent */ parent = ulpi->dev.parent; - if (parent->of_node) + if (of_node_get(parent->of_node)) np = of_find_node_by_name(parent->of_node, "ulpi"); - else if (parent->parent && parent->parent->of_node) + else if (parent->parent && of_node_get(parent->parent->of_node)) np = of_find_node_by_name(parent->parent->of_node, "ulpi"); if (!np) return 0; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project