From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbdKKH4U (ORCPT ); Sat, 11 Nov 2017 02:56:20 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:46547 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751655AbdKKH4S (ORCPT ); Sat, 11 Nov 2017 02:56:18 -0500 X-Google-Smtp-Source: AGs4zMaDGeNxnwQD0Q2JcOxPXTZgZ2bCWgTUbAVt8dr/HuMG9Sa5MUYu7C50S8k35YwIXrlP9uWAgg== Date: Fri, 10 Nov 2017 23:56:12 -0800 From: Bjorn Andersson To: Damien Riegel , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , kernel@savoirfairelinux.com Subject: Re: [PATCH 4/4] arm64: dts: qcom: msm8916: add bindings for i2c1, i2c3, i2c5 Message-ID: <20171111075612.GA1236@tuxbook> References: <20171101175335.22123-1-damien.riegel@savoirfairelinux.com> <20171101175335.22123-5-damien.riegel@savoirfairelinux.com> <20171109170016.GC28761@minitux> <20171109171456.6t3nhig6t4bnkc77@workotop.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171109171456.6t3nhig6t4bnkc77@workotop.localdomain> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 09 Nov 09:14 PST 2017, Damien Riegel wrote: > Hi Bjorn, > > > On Thu, Nov 09, 2017 at 09:00:16AM -0800, Bjorn Andersson wrote: > > On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote: > > > > I think it's better to use the word "nodes" (add nodes...) > > Will reword that. > > > > > > Signed-off-by: Damien Riegel > > > --- > > > arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 72 ++++++++++++++++++++++++++++++ > > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 45 +++++++++++++++++++ > > > 2 files changed, 117 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > > index c67ad8ed8b60..1cec5b30ed6e 100644 > > > --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > > @@ -270,6 +270,30 @@ > > > }; > > > }; > > > > > > + i2c1_default: i2c1_default { > > > + pinmux { > > > + function = "blsp_i2c1"; > > > + pins = "gpio2", "gpio3"; > > > + }; > > > + pinconf { > > > + pins = "gpio2", "gpio3"; > > > + drive-strength = <16>; > > > + bias-disable; > > > + }; > > > > pinconf is typically board specific, so please leave these out from the > > base dtsi. > > I don't mind dropping that, but pinconf for i2c{2,4,6} is already in > msm8916-pins.dtsi, so we should either drop them all, or add pinconf for > i2c{1,3,5} for consistency. You're right, this needs to be consistent. So I would like us to update the existing nodes, > And if I read the pinctrl driver correctly, > I2C cannot be routed to other pins, the only properties that users may > want to modify are drive-strength and bias. Let me know which option you > prefer. > I discussed the matter with my colleagues and we concluded that we want to keep the muxing in the platform.dtsi and move the specification of the electrical properties (pinconf) to the board.dts(i). We did discuss having some "default values" in the platform file, but pushing these down to the board file gives an indication to others that these values are board specific. PS. If you're willing to provide a patch for the existing nodes I would be happy to review this as well! Regards, Bjorn