From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbdKKIqp (ORCPT ); Sat, 11 Nov 2017 03:46:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:55834 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751514AbdKKIqo (ORCPT ); Sat, 11 Nov 2017 03:46:44 -0500 Date: Sat, 11 Nov 2017 09:46:53 +0100 From: Greg Kroah-Hartman To: Finn Thain Cc: Geert Uytterhoeven , linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/14] nubus: Add support for the driver model Message-ID: <20171111084653.GB6403@kroah.com> References: <6c64ec1ff338853f8ba34783e70896565f968854.1510377369.git.fthain@telegraphics.com.au> <20171111084553.GA6403@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171111084553.GA6403@kroah.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 11, 2017 at 09:45:53AM +0100, Greg Kroah-Hartman wrote: > On Sat, Nov 11, 2017 at 01:12:49AM -0500, Finn Thain wrote: > > Cc: Greg Kroah-Hartman > > Tested-by: Stan Johnson > > Signed-off-by: Finn Thain > > --- > > I can't take patches without any changelog text at all, that's not good > engineering, sorry :( > > Please fix up and resend and I will be glad to review. Also, please test device removal, I don't think you did that :(