From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751456AbdKKJVP (ORCPT <rfc822;w@1wt.eu>);
        Sat, 11 Nov 2017 04:21:15 -0500
Received: from mail.kernel.org ([198.145.29.99]:46296 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750799AbdKKJVM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 11 Nov 2017 04:21:12 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A9D75218CA
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=leon@kernel.org
Date: Sat, 11 Nov 2017 11:21:05 +0200
From: Leon Romanovsky <leon@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Doug Ledford <dledford@redhat.com>, Christoph Hellwig <hch@lst.de>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        Matan Barak <matanb@mellanox.com>, Yishai Hadas <yishaih@mellanox.com>,
        Sean Hefty <sean.hefty@intel.com>,
        Dasaratharaman Chandramouli 
        <dasaratharaman.chandramouli@intel.com>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: avoid uninitialized variable warning in
 create_udata
Message-ID: <20171111092105.GU18825@mtr-leonro.local>
References: <20171110221053.3549147-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="7AfkfStYJxYILZKr"
Content-Disposition: inline
In-Reply-To: <20171110221053.3549147-1-arnd@arndb.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--7AfkfStYJxYILZKr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Nov 10, 2017 at 11:10:31PM +0100, Arnd Bergmann wrote:
> As Dan pointed out, the rework I did makes it harder for smatch and other
> static checkers to figure out what is going on with the uninitialized
> pointers.
>
> By open-coding the call in create_udata(), we make it more readable for
> both humans and tools.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Fixes: 12f727721eee ("IB/uverbs: clean up INIT_UDATA_BUF_OR_NULL usage")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/infiniband/core/uverbs_std_types.c | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

--7AfkfStYJxYILZKr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAloGwQEACgkQ5GN7iDZy
WKcIOw/+KPEqEybCJl2f4IBmQe1yLyFvl3gBUVS9LNhCjOrqGAUjxo8M/GBAqu2W
J7W9jaBcs+zDnN7FO5JgoyHzHsD4U4CTZfFK5jjCPmWre0I5rU7t7i1sOeSkJOH0
OdUHFWjXAPVyShJFqdCB7fUwVNiMNr3ePnAv+tKyxwlCBetMXyf1+aPayZKlGAlX
KvM+beb/P5JOKFOSIAy36RYkfrHesS/a2FXF87CIuqaQhs1VOuhP2SPi0ibFQ+2+
HO9SHkoyQlLwJct1klrQS6zvaGKeCiFmjK550c/QdawoGVfIMz53Gn5wvneYUpIy
jCMoompMd8HwXn0KmZhy0ZPckOJs9wTrXgv2kzBdOEW8ruP3iQPSE8sV38HEplbZ
davBQaPSMTTGEwF+3JPZR0/KKywmYEPoq5ss5PLZh2X/7NbVMGvFPDvAKnGRkKP7
bPQyxpHfG2aQtJMqI6HGFKYLVXtYRgSeyl6rjsQbnnxdWi4SjLbm1mZYBxCsttn6
Cj8a7wLN27EXUHeE9f7VOmYUn5SZdRxKQMs87NG4oLqZcaw7BqFW58ZFHo31cGti
H/Le4VZwRMhHNZ9MFlI4YuRvPfKXyHDybEaKAPlDRR5yJ821F8pDDrkyWMUWU6rp
6qXu8vdb5qi1fWn8h7cwxuT4KdJQnjHB82zyK3Qhll7Jhs+rXto=
=ZHXs
-----END PGP SIGNATURE-----

--7AfkfStYJxYILZKr--