From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750978AbdKLRQl (ORCPT ); Sun, 12 Nov 2017 12:16:41 -0500 Received: from mga02.intel.com ([134.134.136.20]:31088 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846AbdKLRQk (ORCPT ); Sun, 12 Nov 2017 12:16:40 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,385,1505804400"; d="scan'208";a="1815973" Date: Mon, 13 Nov 2017 01:15:42 +0800 From: kbuild test robot To: Yafang Shao Cc: kbuild-all@01.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, rostedt@goodmis.org, mingo@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Yafang Shao Subject: Re: [PATCH net-next 1/2] net/tcp: track all TCP/IP state transition in tcp_set_state Message-ID: <201711130018.7unIA9zv%fengguang.wu@intel.com> References: <1510237564-6013-1-git-send-email-laoar.shao@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1510237564-6013-1-git-send-email-laoar.shao@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Yafang, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Yafang-Shao/net-tcp-track-all-TCP-IP-state-transition-in-tcp_set_state/20171112-203643 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) vim +/return +428 net/netfilter/ipvs/ip_vs_proto_tcp.c ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 423 ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 @424 static const char * tcp_state_name(int state) ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 425 { ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 426 if (state >= IP_VS_TCP_S_LAST) ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 427 return "ERR!"; ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 @428 return tcp_state_name_table[state] ? tcp_state_name_table[state] : "?"; ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 429 } ^1da177e net/ipv4/ipvs/ip_vs_proto_tcp.c Linus Torvalds 2005-04-16 430 :::::: The code at line 428 was first introduced by commit :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 :::::: TO: Linus Torvalds :::::: CC: Linus Torvalds --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation