From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752363AbdKMJNB (ORCPT ); Mon, 13 Nov 2017 04:13:01 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:32792 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbdKMJM7 (ORCPT ); Mon, 13 Nov 2017 04:12:59 -0500 X-Google-Smtp-Source: AGs4zMaO1dbPrLznrdeHQ38toOGmHGThd+3HfEq1Hbw5MhLAL2dS8/nV9AuvUJhpWEBwvQN3giMJDQ== Date: Mon, 13 Nov 2017 09:12:56 +0000 From: Lee Jones To: Johan Hovold Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable , Peter Ujfalusi , Samuel Ortiz Subject: Re: [PATCH 2/2] mfd: twl6040: fix child-node lookup Message-ID: <20171113091256.6prmqkvtlhmebmij@dell> References: <20171111153844.16741-1-johan@kernel.org> <20171111153844.16741-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171111153844.16741-2-johan@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 11 Nov 2017, Johan Hovold wrote: > Fix child-node lookup during probe, which ended up searching the whole > device tree depth-first starting at the parent rather than just matching > on its children. > > To make things worse, the parent node was prematurely freed, while the > child node was leaked. > > Note that the CONFIG_OF compile guard can be removed as > of_get_child_by_name() provides a !CONFIG_OF implementation which always > fails. > > Fixes: 37e13cecaa14 ("mfd: Add support for Device Tree to twl6040") > Fixes: ca2cad6ae38e ("mfd: Fix twl6040 build failure") > Cc: stable # 3.5 > Cc: Peter Ujfalusi > Cc: Samuel Ortiz > --- > drivers/mfd/twl6040.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) For my own reference: Acked-for-MFD-by: Lee Jones I'll pick these up later in the cycle. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog