From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753979AbdKNSHp (ORCPT ); Tue, 14 Nov 2017 13:07:45 -0500 Received: from mail-lf0-f42.google.com ([209.85.215.42]:56825 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbdKNSHj (ORCPT ); Tue, 14 Nov 2017 13:07:39 -0500 X-Google-Smtp-Source: AGs4zMbUAssZFK9epd5J5XLPz7evqHnHTj2Ji/MMOGtQWDbKoH88dNYzGc83kaKKbqcGhgK6StWgRw== Date: Tue, 14 Nov 2017 19:07:43 +0100 From: Johan Hovold To: Peter Ujfalusi Cc: Johan Hovold , Tony Lindgren , Lee Jones , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, stable Subject: Re: [PATCH 1/2] mfd: twl4030-audio: fix sibling-node lookup Message-ID: <20171114180743.GB11226@localhost> References: <20171111153844.16741-1-johan@kernel.org> <189caf41-7298-ab1e-6a67-f6ff86fea47f@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <189caf41-7298-ab1e-6a67-f6ff86fea47f@ti.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 10:13:42PM +0200, Peter Ujfalusi wrote: > On 11/11/2017 05:38 PM, Johan Hovold wrote: > > A helper purported to look up a child node based on its name was using > > the wrong of-helper and ended up prematurely freeing the parent of-node > > while leaking any matching node. > > > > To make things worse, any matching node would not even necessarily be a > > child node as the whole device tree was searched depth-first starting at > > the parent. > > I think it is the same case as with the twl6040, there were no > of_get_child_by_name() when this was done... > > Thanks for fixing it! > > Acked-by: Peter Ujfalusi Thanks for the acks. Johan