From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756902AbdKNXNy (ORCPT ); Tue, 14 Nov 2017 18:13:54 -0500 Received: from mail.savoirfairelinux.com ([208.88.110.44]:33164 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755093AbdKNXNo (ORCPT ); Tue, 14 Nov 2017 18:13:44 -0500 Date: Tue, 14 Nov 2017 18:13:42 -0500 From: Damien Riegel To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , kernel@savoirfairelinux.com Subject: Re: [PATCH 4/4] arm64: dts: qcom: msm8916: add bindings for i2c1, i2c3, i2c5 Message-ID: <20171114231342.vh7xy3xbsyyb5wfn@workotop.localdomain> Mail-Followup-To: Damien Riegel , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andy Gross , David Brown , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , kernel@savoirfairelinux.com References: <20171101175335.22123-1-damien.riegel@savoirfairelinux.com> <20171101175335.22123-5-damien.riegel@savoirfairelinux.com> <20171109170016.GC28761@minitux> <20171109171456.6t3nhig6t4bnkc77@workotop.localdomain> <20171111075612.GA1236@tuxbook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171111075612.GA1236@tuxbook> User-Agent: NeoMutt/20171013 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 10, 2017 at 11:56:12PM -0800, Bjorn Andersson wrote: > On Thu 09 Nov 09:14 PST 2017, Damien Riegel wrote: > > > Hi Bjorn, > > > > > > On Thu, Nov 09, 2017 at 09:00:16AM -0800, Bjorn Andersson wrote: > > > On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote: > > > > > > I think it's better to use the word "nodes" (add nodes...) > > > > Will reword that. > > > > > > > > > Signed-off-by: Damien Riegel > > > > --- > > > > arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 72 ++++++++++++++++++++++++++++++ > > > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 45 +++++++++++++++++++ > > > > 2 files changed, 117 insertions(+) > > > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > > > index c67ad8ed8b60..1cec5b30ed6e 100644 > > > > --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > > > @@ -270,6 +270,30 @@ > > > > }; > > > > }; > > > > > > > > + i2c1_default: i2c1_default { > > > > + pinmux { > > > > + function = "blsp_i2c1"; > > > > + pins = "gpio2", "gpio3"; > > > > + }; > > > > + pinconf { > > > > + pins = "gpio2", "gpio3"; > > > > + drive-strength = <16>; > > > > + bias-disable; > > > > + }; > > > > > > pinconf is typically board specific, so please leave these out from the > > > base dtsi. > > > > I don't mind dropping that, but pinconf for i2c{2,4,6} is already in > > msm8916-pins.dtsi, so we should either drop them all, or add pinconf for > > i2c{1,3,5} for consistency. > > You're right, this needs to be consistent. So I would like us to update > the existing nodes, > > > And if I read the pinctrl driver correctly, > > I2C cannot be routed to other pins, the only properties that users may > > want to modify are drive-strength and bias. Let me know which option you > > prefer. > > > > I discussed the matter with my colleagues and we concluded that we want > to keep the muxing in the platform.dtsi and move the specification of > the electrical properties (pinconf) to the board.dts(i). > > We did discuss having some "default values" in the platform file, but > pushing these down to the board file gives an indication to others that > these values are board specific. Okay that makes sense. I'll work on a patchset to do that. Regards, -- Damien