From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932294AbdKOKh5 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 15 Nov 2017 05:37:57 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:46868 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932136AbdKOKht (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Nov 2017 05:37:49 -0500
Date: Wed, 15 Nov 2017 11:37:42 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Prateek Sood <prsood@codeaurora.org>
Cc: longman@redhat.com, tj@kernel.org, lizefan@huawei.com,
        mingo@kernel.org, boqun.feng@gmail.com, tglx@linutronix.de,
        cgroups@vger.kernel.org, sramana@codeaurora.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cgroup/cpuset: remove circular dependency deadlock
Message-ID: <20171115103742.xt7muaq2dfrs2cyd@hirez.programming.kicks-ass.net>
References: <45cdac2f-4462-e5b5-d724-8cca58e3932a@codeaurora.org>
 <1509347805-23491-1-git-send-email-prsood@codeaurora.org>
 <6f8b194f-05ec-05d4-3df6-e9eadc7f68bf@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6f8b194f-05ec-05d4-3df6-e9eadc7f68bf@codeaurora.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 15, 2017 at 03:56:26PM +0530, Prateek Sood wrote:
> Any improvement/suggestion for this patch?

I would have done 2 patches, the first one solving the locking issue,
the second removing the then redundant async rebuild stuff.

Other than that this looks OK I suppose, but I was expecting this to go
through the cgroup tree, TJ?