Re: Logically dead code at fs/afs/cell.c:206

From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: Logically dead code at fs/afs/cell.c:206
Date: Fri, 17 Nov 2017 16:26:16 -0600	[thread overview]
Message-ID: <20171117162616.Horde.VzOsCimCLXyyQJfEt3LNf9n@gator4166.hostgator.com> (raw)
In-Reply-To: <4923.1510957307@warthog.procyon.org.uk>

Quoting David Howells <dhowells@redhat.com>:

> Gustavo A. R. Silva <garsilva@embeddedor.com> wrote:
>
>> Today Coverity reported a "Logically dead code" issue at fs/afs/cell.c:206:
>>
>>         if (!excl) {
>>                 rcu_read_lock();
>>                 cell = afs_lookup_cell_rcu(net, name, namesz);
>>                 rcu_read_unlock();
>>                 if (!IS_ERR(cell)) {
>>                         if (excl) {
>>                                 afs_put_cell(net, cell);
>>                                 return ERR_PTR(-EEXIST);
>>                         }
>>                         goto wait_for_cell;
>>                 }
>>         }
>>
>> The problem is that when this code block is executed, the code block
>> starting at line 211 makes no sense, as _excl_ can never be true.
>
> Good catch.  The interior "if (excl) { ... }" statement and body needs
> removing entirely.  Originally the outer "if (!excl)" wrapping it wasn't
> there.
>

I'll send a patch to remove that code.

Thanks for clarifying.
--
Gustavo A. R. Silva