From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: peter enderborg <peter.enderborg@sony.com>
Cc: Romain Perier <romain.perier@gmail.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@codeaurora.org>, <linux-api@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] time: Make NTP optionnal
Date: Mon, 20 Nov 2017 16:08:53 +0000 [thread overview]
Message-ID: <20171120160853.2a1bb7b2@alans-desktop> (raw)
In-Reply-To: <24617dd4-66ed-d7c9-4c2c-8ad2faac7b72@sony.com>
On Mon, 20 Nov 2017 16:22:06 +0100
peter enderborg <peter.enderborg@sony.com> wrote:
> On 11/20/2017 04:00 PM, Romain Perier wrote:
> > Hi,
> >
> > 2017-11-20 15:10 GMT+01:00 peter enderborg <peter.enderborg@sony.com>:
> >> I think it should return a error code at least.
> > In which case ? The idea was to don't change the behaviour of these
> > functions (from the "API" point of view) and to avoid regressions in
> > the kernel components that depend on these NTP feature.
> > (so be transparent the most as possible)
> >
> > Thanks,
> > Romain
> >
>
> do_adjtimex should return -ENOSYS in my opinion, however it is not in the manual
> that it can return ENOSYS.
The standards specifications state what must be returned for certain
error cases, they don't forbid other errors being added.
Old old Linx will of course already return -1,ENOSYS to this call.
Alan
next prev parent reply other threads:[~2017-11-20 16:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 18:29 [PATCH] time: Make NTP optionnal Romain Perier
2017-11-20 13:52 ` Romain Perier
2017-11-20 14:10 ` peter enderborg
2017-11-20 15:00 ` Romain Perier
2017-11-20 15:22 ` peter enderborg
2017-11-20 16:08 ` Alan Cox [this message]
2017-11-20 16:29 ` Romain Perier
2017-11-20 16:39 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120160853.2a1bb7b2@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=john.stultz@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.enderborg@sony.com \
--cc=romain.perier@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).