From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbdKVVLh (ORCPT ); Wed, 22 Nov 2017 16:11:37 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:37394 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbdKVVIU (ORCPT ); Wed, 22 Nov 2017 16:08:20 -0500 From: Matthew Wilcox To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Matthew Wilcox Subject: [PATCH 53/62] irq: Remove call to idr_preload Date: Wed, 22 Nov 2017 13:07:30 -0800 Message-Id: <20171122210739.29916-54-willy@infradead.org> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20171122210739.29916-1-willy@infradead.org> References: <20171122210739.29916-1-willy@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Matthew Wilcox Not entirely clear why the preload was there with no locking. Maybe at one time there was a lock, and the preload was never removed? Signed-off-by: Matthew Wilcox --- kernel/irq/timings.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index e0923fa4927a..e9f16527656c 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/timings.c @@ -356,9 +356,7 @@ int irq_timings_alloc(int irq) if (!s) return -ENOMEM; - idr_preload(GFP_KERNEL); - id = idr_alloc(&irqt_stats, s, irq, irq + 1, GFP_NOWAIT); - idr_preload_end(); + id = idr_alloc(&irqt_stats, s, irq, irq + 1, GFP_KERNEL); if (id < 0) { free_percpu(s); -- 2.15.0