From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751710AbdKVWYF (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Nov 2017 17:24:05 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:38681 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751590AbdKVWYD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Nov 2017 17:24:03 -0500
Date: Wed, 22 Nov 2017 14:24:02 -0800
From: Matthew Wilcox <willy@infradead.org>
To: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Matthew Wilcox <mawilcox@microsoft.com>
Subject: Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t
Message-ID: <20171122222402.GA13634@bombadil.infradead.org>
References: <20171122210739.29916-1-willy@infradead.org>
 <20171122210739.29916-6-willy@infradead.org>
 <20171122212847.axib6ito23sldlbe@ltop.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171122212847.axib6ito23sldlbe@ltop.local>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Nov 22, 2017 at 10:28:48PM +0100, Luc Van Oostenryck wrote:
> > -	root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1;
> > +	root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1);
> 
> IMO, it would be better to define something for that in radix-tree.h,
> like it has been done for ROOT_IS_IDR.

If we were keeping the radix tree around, I'd agree, but the point of
the rest of this patch set is replacing it ;-)  I should probably have
just dropped this patch, to be honest.