From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbdKVWfP (ORCPT ); Wed, 22 Nov 2017 17:35:15 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:39252 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbdKVWfK (ORCPT ); Wed, 22 Nov 2017 17:35:10 -0500 X-Google-Smtp-Source: AGs4zMaE/pUxpaWoKvsHpb5JKAr1owQaD8OoAbeLjWFknmvo5FPikMOAMfVSJrfZw3TktGyHXrqIvQ== Date: Wed, 22 Nov 2017 23:35:03 +0100 From: Luc Van Oostenryck To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH 05/62] radix tree: Add a missing cast to gfp_t Message-ID: <20171122223501.6qtgsyy5ixpuel4d@ltop.local> References: <20171122210739.29916-1-willy@infradead.org> <20171122210739.29916-6-willy@infradead.org> <20171122212847.axib6ito23sldlbe@ltop.local> <20171122222402.GA13634@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171122222402.GA13634@bombadil.infradead.org> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 02:24:02PM -0800, Matthew Wilcox wrote: > On Wed, Nov 22, 2017 at 10:28:48PM +0100, Luc Van Oostenryck wrote: > > > - root->gfp_mask &= (1 << ROOT_TAG_SHIFT) - 1; > > > + root->gfp_mask &= (__force gfp_t)((1 << ROOT_TAG_SHIFT) - 1); > > > > IMO, it would be better to define something for that in radix-tree.h, > > like it has been done for ROOT_IS_IDR. > > If we were keeping the radix tree around, I'd agree, but the point of > the rest of this patch set is replacing it ;-) I should probably have > just dropped this patch, to be honest. Ah OK, sure. I confess I didn't saw the whole series, just this patch. -- Luc