From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752146AbdKWBeF (ORCPT ); Wed, 22 Nov 2017 20:34:05 -0500 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:12122 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751525AbdKWBeE (ORCPT ); Wed, 22 Nov 2017 20:34:04 -0500 Date: Thu, 23 Nov 2017 12:25:01 +1100 From: Dave Chinner To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH 00/62] XArray November 2017 Edition Message-ID: <20171123012501.GK4094@dastard> References: <20171122210739.29916-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171122210739.29916-1-willy@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 22, 2017 at 01:06:37PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I've lost count of the number of times I've posted the XArray before, > so time for a new numbering scheme. Here're two earlier versions, > https://lkml.org/lkml/2017/3/17/724 > https://lwn.net/Articles/715948/ (this one's more loquacious in its > description of things that are better about the radix tree API than the > XArray). > > This time around, I've gone for an approach of many small changes. > Unfortunately, that means you get 62 moderate patches instead of dozens > of big ones. Where's the API documentation that tells things like constraints about locking and lock-less lookups via RCU? e.g. I notice in the XFS patches you seem to randomly strip out rcu_read_lock/unlock() pairs that are currently around radix tree lookup operations without explanation. Without documentation describing how this stuff is supposed to work, review is somewhat difficult... Cheers, Dave. -- Dave Chinner david@fromorbit.com