From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: davem@davemloft.net
Cc: hayeswang@realtek.co, linux-usb@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Mario Limonciello <mario.limonciello@dell.com>
Subject: [PATCH] r8152: disable rx checksum offload on Dell TB dock
Date: Thu, 23 Nov 2017 01:38:38 -0500 [thread overview]
Message-ID: <20171123063838.3058-1-kai.heng.feng@canonical.com> (raw)
r8153 on Dell TB dock corrupts rx packets.
The root cause is not found yet, but disabling rx checksumming can
workaround the issue. We can use this connection to decide if it's
a Dell TB dock:
Realtek r8153 <-> SMSC hub <-> ASMedia XHCI controller
BugLink: https://bugs.launchpad.net/bugs/1729674
Cc: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
drivers/net/usb/r8152.c | 33 ++++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index d51d9abf7986..58b80b5e7803 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -27,6 +27,8 @@
#include <linux/usb/cdc.h>
#include <linux/suspend.h>
#include <linux/acpi.h>
+#include <linux/pci.h>
+#include <linux/usb/hcd.h>
/* Information for net-next */
#define NETNEXT_VERSION "09"
@@ -5135,6 +5137,35 @@ static u8 rtl_get_version(struct usb_interface *intf)
return version;
}
+/* Ethernet on Dell TB 15/16 dock is connected this way:
+ * Realtek r8153 <-> SMSC hub <-> ASMedia XHCI controller
+ * We use this connection to make sure r8153 is on the Dell TB dock.
+ */
+static bool check_dell_tb_dock(struct usb_device *udev)
+{
+ struct usb_device *hub = udev->parent;
+ struct usb_device *root_hub;
+ struct pci_dev *controller;
+
+ if (!hub)
+ return false;
+
+ if (!(le16_to_cpu(hub->descriptor.idVendor) == 0x0424 &&
+ le16_to_cpu(hub->descriptor.idProduct) == 0x5537))
+ return false;
+
+ root_hub = hub->parent;
+ if (!root_hub || root_hub->parent)
+ return false;
+
+ controller = to_pci_dev(bus_to_hcd(root_hub->bus)->self.controller);
+
+ if (controller->vendor == 0x1b21 && controller->device == 0x1142)
+ return true;
+
+ return false;
+}
+
static int rtl8152_probe(struct usb_interface *intf,
const struct usb_device_id *id)
{
@@ -5202,7 +5233,7 @@ static int rtl8152_probe(struct usb_interface *intf,
NETIF_F_HIGHDMA | NETIF_F_FRAGLIST |
NETIF_F_IPV6_CSUM | NETIF_F_TSO6;
- if (tp->version == RTL_VER_01) {
+ if (tp->version == RTL_VER_01 || check_dell_tb_dock(udev)) {
netdev->features &= ~NETIF_F_RXCSUM;
netdev->hw_features &= ~NETIF_F_RXCSUM;
}
--
2.14.1
next reply other threads:[~2017-11-23 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 6:38 Kai-Heng Feng [this message]
2017-11-23 7:58 ` [PATCH] r8152: disable rx checksum offload on Dell TB dock Greg KH
2017-11-23 8:53 ` Kai Heng Feng
2017-11-23 9:24 ` Greg KH
2017-11-24 3:44 ` Kai Heng Feng
2017-11-24 8:28 ` Greg KH
2017-11-24 8:29 ` Greg KH
2017-11-24 8:59 ` Kai Heng Feng
2017-11-27 15:11 ` Mario.Limonciello
2017-11-24 8:57 ` Kai Heng Feng
2017-11-27 15:13 ` Mario.Limonciello
2017-11-28 9:40 ` Kai Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123063838.3058-1-kai.heng.feng@canonical.com \
--to=kai.heng.feng@canonical.com \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.co \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).