From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752724AbdKWLoW (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Nov 2017 06:44:22 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:51545 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751799AbdKWLoU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Nov 2017 06:44:20 -0500
Date: Thu, 23 Nov 2017 14:43:36 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Ching Huang <ching2048@areca.com.tw>
Cc: martin.petersen@oracle.com, James.Bottomley@HansenPartnership.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        jthumshirn@suse.de, hare@suse.de, hch@infradead.org
Subject: Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable
Message-ID: <20171123114336.bnekgwbrdbx7kvnn@mwanda>
References: <1511400674.9832.23.camel@Centos6.3-64>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1511400674.9832.23.camel@Centos6.3-64>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Source-IP: userv0022.oracle.com [156.151.31.74]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote:
> @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev,
>  	unsigned long flags;
>  	int nvec, i;
>  
> +	if (msix_enable == 0)
> +		goto msi_int0;

I feel like this goto is not very beautiful, but I can't actually apply
this patch?  Which tree is this written against?  I'm using linux-next.

regards,
dan carpenter