linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: peter enderborg <peter.enderborg@sony.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alex Deucher <alexander.deucher@amd.com>,
	"David S . Miller" <davem@davemloft.net>,
	Harry Wentland <Harry.Wentland@amd.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Tony Cheng <Tony.Cheng@amd.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Mel Gorman <mgorman@techsingularity.net>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Pavel Tatashin <pasha.tatashin@oracle.com>
Subject: Re: [PATCH] Add slowpath enter/exit trace events
Date: Thu, 23 Nov 2017 13:47:38 +0100	[thread overview]
Message-ID: <20171123124738.nj7foesbajo42t3g@dhcp22.suse.cz> (raw)
In-Reply-To: <ef88ca71-b41b-f5e9-fd41-d02676bad1cf@sony.com>

On Thu 23-11-17 13:35:15, peter enderborg wrote:
> Monitoring both enter/exit for all allocations and track down the one
> that are slow will be a very big load on mobile devices or embedded
> device consuming a lot of battery and cpu. With this we can do useful
> monitoring on devices on our field tests with real usage.

This might be true but the other POV is that the trace point with the
additional information is just too disruptive to the rest of the code
and it exposes too many implementation details.
-- 
Michal Hocko
SUSE Labs

  reply	other threads:[~2017-11-23 12:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 10:43 [PATCH] Add slowpath enter/exit trace events peter.enderborg
2017-11-23 12:25 ` Michal Hocko
2017-11-23 12:35   ` peter enderborg
2017-11-23 12:47     ` Michal Hocko [this message]
2017-11-23 13:03       ` peter enderborg
2017-11-23 13:47         ` Michal Hocko
2017-11-23 13:36   ` Mel Gorman
2017-11-23 13:43     ` Tetsuo Handa
2017-11-24  7:43       ` peter enderborg
2017-11-23 14:01     ` Michal Hocko
2017-11-23 15:09       ` Mel Gorman
2017-11-24  8:38       ` peter enderborg
2017-11-23 13:00 ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171123124738.nj7foesbajo42t3g@dhcp22.suse.cz \
    --to=mhocko@kernel.org \
    --cc=Harry.Wentland@amd.com \
    --cc=Tony.Cheng@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=alexander.deucher@amd.com \
    --cc=davem@davemloft.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mingo@redhat.com \
    --cc=pasha.tatashin@oracle.com \
    --cc=peter.enderborg@sony.com \
    --cc=rostedt@goodmis.org \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).