From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752981AbdKXEUq (ORCPT ); Thu, 23 Nov 2017 23:20:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34094 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbdKXEUp (ORCPT ); Thu, 23 Nov 2017 23:20:45 -0500 Date: Fri, 24 Nov 2017 06:20:35 +0200 From: "Michael S. Tsirkin" To: Christoph Hellwig Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , linux-kernel@vger.kernel.org, somlo@cmu.edu, xiaolong.ye@intel.com, qemu-devel@nongnu.org, Andrew Morton , Baoquan He , Dave Young , Hari Bathini , Tony Luck , Vivek Goyal Subject: Re: [PATCH v8 4/5] crash: export paddr_vmcoreinfo_note() Message-ID: <20171124061759-mutt-send-email-mst@kernel.org> References: <20171123140206.3911-1-marcandre.lureau@redhat.com> <20171123140206.3911-5-marcandre.lureau@redhat.com> <20171123143657.GA19971@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171123143657.GA19971@infradead.org> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 24 Nov 2017 04:20:45 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 23, 2017 at 06:36:57AM -0800, Christoph Hellwig wrote: > On Thu, Nov 23, 2017 at 03:02:05PM +0100, Marc-André Lureau wrote: > > The following patch is going to use the symbol from the fw_cfg module, > > to call the function and write the note location details in the > > vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note. > > Sounds like fw_cfg should be moved to be built in only instead of > exporting such a symbol address. Point is, all fw cfg does is export it on to the hypervisor, so it will have to be supported forever. If it's safe to export it to the hypervisor then for sure it's also safe to export it to modules. -- MST