From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: <alsa-devel@alsa-project.org>, <patches@opensource.cirrus.com>,
"Jaroslav Kysela" <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 2/4] ASoC: wm2000: One function call less in wm2000_i2c_probe() after error detection
Date: Fri, 24 Nov 2017 08:34:25 +0000 [thread overview]
Message-ID: <20171124083425.jwjdppt4mpl55r4p@localhost.localdomain> (raw)
In-Reply-To: <e09f6361-8d58-c534-4aaa-cafb7f801726@users.sourceforge.net>
On Fri, Nov 24, 2017 at 08:37:41AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 24 Nov 2017 07:45:59 +0100
>
> The release_firmware() function was called in a few cases by the
> wm2000_i2c_probe() function during error handling even if
> the passed variable contained a null pointer.
>
> * Adjust jump targets according to the Linux coding style convention.
>
> * Delete the label "out" and an initialisation for the variable "fw"
> at the beginning which became unnecessary with this refactoring.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2017-11-24 8:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 7:34 [PATCH 0/4] ASoC: wm2000: Adjustments for wm2000_i2c_probe() SF Markus Elfring
2017-11-24 7:36 ` [PATCH 1/4] ASoC: wm2000: Delete an error message for a failed memory allocation in wm2000_i2c_probe() SF Markus Elfring
2017-11-24 8:11 ` Charles Keepax
2017-11-27 18:54 ` Applied "ASoC: wm2000: Delete an error message for a failed memory allocation in wm2000_i2c_probe()" to the asoc tree Mark Brown
2017-11-24 7:37 ` [PATCH 2/4] ASoC: wm2000: One function call less in wm2000_i2c_probe() after error detection SF Markus Elfring
2017-11-24 8:34 ` Charles Keepax [this message]
2017-11-24 7:39 ` [PATCH 3/4] ASoC: wm2000: Fix a typo in a comment line SF Markus Elfring
2017-11-24 8:34 ` Charles Keepax
2017-11-27 18:54 ` Applied "ASoC: wm2000: Fix a typo in a comment line" to the asoc tree Mark Brown
2017-11-24 7:40 ` [PATCH 4/4] ASoC: wm2000: Improve a size determination in wm2000_i2c_probe() SF Markus Elfring
2017-11-24 8:34 ` Charles Keepax
2017-11-27 18:54 ` Applied "ASoC: wm2000: Improve a size determination in wm2000_i2c_probe()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124083425.jwjdppt4mpl55r4p@localhost.localdomain \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=elfring@users.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).