From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753518AbdKXM4R (ORCPT ); Fri, 24 Nov 2017 07:56:17 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53776 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753227AbdKXM4Q (ORCPT ); Fri, 24 Nov 2017 07:56:16 -0500 Date: Fri, 24 Nov 2017 12:55:58 +0000 From: Mark Brown To: Adam Thomson Cc: SF Markus Elfring , "alsa-devel@alsa-project.org" , Support Opensource , Jaroslav Kysela , Liam Girdwood , Takashi Iwai , LKML , "kernel-janitors@vger.kernel.org" Subject: Re: [PATCH 2/3] ASoC: da7218: Use common error handling code in da7218_of_to_pdata() Message-ID: <20171124125558.uvfognezm75dtlbc@sirena.org.uk> References: <07c631e4-e2df-7ae2-ea31-9430c89dc8e3@users.sourceforge.net> <32a4c9e8-2030-c4e8-eb54-9ce6712ef0cd@users.sourceforge.net> <2E89032DDAA8B9408CB92943514A0337014C1B11E5@SW-EX-MBX01.diasemi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iknjngorugptk2nb" Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1B11E5@SW-EX-MBX01.diasemi.com> X-Cookie: Given my druthers, I'd druther not. User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iknjngorugptk2nb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 24, 2017 at 12:03:32PM +0000, Adam Thomson wrote: > On 23 November 2017 20:06, SF Markus Elfring wrote: > > Add a jump target so that a bit of exception handling can be better reused > > in an if branch of this function. > Hmm. Doesn't really gain an awful lot this. Would understand if there were > multiple return paths, but in that case I'd have implemented something like > this anyway. Also your patch description isn't really correct. You're re-using > code from the sunny day scenario to handle an exception. Other people have given him similar feedback on his other patches with this pattern. I'm not intending to apply any of them. --iknjngorugptk2nb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAloYFt4ACgkQJNaLcl1U h9AH+Qf/ZNLVfptwWMgGXUEo2FNyi+pp1AW+I/dxOjNK9lN0pOwFEQh7/NlZSzz6 jSqnLjG80HEWhJEAsXHrE/DiNBP+8xNRRVZJogfyuoIHlLiu0mrug4nENANtG0fE Z18UwDmTpoj0bL//sjVE07ugNVxH173wYJ3rhEM4rXCl8pavW3GQ4WSB/tRCEXDl c6SEU2BZDJ9u2xxTeXRfSinfaluqdxpz/Y2Gc7idO+M9Pf83JKPDj23pps2rxgoM lwPOvZX/FyRiXo+Q1r1fM2ruGtKvK+Br2cYvDDR0zHjg48yUdiPdPmQVhPTT46Rc PjQLG94Etgqj7H5UT9GOgNooi+jekw== =1NLI -----END PGP SIGNATURE----- --iknjngorugptk2nb--