Re: [PATCH v6 07/11] intel_sgx: ptrace() support

From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Joe Perches <joe@perches.com>
Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org,
	linux-kernel@vger.kernel.org, Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>
Subject: Re: [PATCH v6 07/11] intel_sgx: ptrace() support
Date: Sun, 26 Nov 2017 18:53:21 +0200	[thread overview]
Message-ID: <20171126165321.ldpnudpiqyjsuv3v@linux.intel.com> (raw)
In-Reply-To: <1511711405.20482.23.camel@perches.com>

On Sun, Nov 26, 2017 at 07:50:05AM -0800, Joe Perches wrote:
> On Sun, 2017-11-26 at 17:44 +0200, Jarkko Sakkinen wrote:
> > On Sat, Nov 25, 2017 at 09:29:24PM +0200, Jarkko Sakkinen wrote:
> > > +	ptr = sgx_get_page(page->epc_page);
> > > +	ret = __edbgrd((unsigned long)ptr + offset, data);
> 	        ^^^^^^
> 
> > > +	sgx_put_page(ptr);
> > > +	if (ret) {
> > > +		sgx_dbg(encl, "EDBGRD returned %d\n", ret);
> >                                ~~~~~~
> > 			       EDBGWR
> 
> ?

D'oh I meant to quote this part:

	ptr = sgx_get_page(page->epc_page);
	ret = __edbgwr((unsigned long)ptr + offset, data);
	sgx_put_page(ptr);
	if (ret) {
		sgx_dbg(encl, "EDBGRD returned %d\n", ret);
		return -EFAULT;
	}

There's a typo in sgx_dbg().

/Jarkko