From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090AbdKZQx0 (ORCPT ); Sun, 26 Nov 2017 11:53:26 -0500 Received: from mga06.intel.com ([134.134.136.31]:22731 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751322AbdKZQxY (ORCPT ); Sun, 26 Nov 2017 11:53:24 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,459,1505804400"; d="scan'208";a="180774743" Date: Sun, 26 Nov 2017 18:53:21 +0200 From: Jarkko Sakkinen To: Joe Perches Cc: platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Darren Hart , Andy Shevchenko Subject: Re: [PATCH v6 07/11] intel_sgx: ptrace() support Message-ID: <20171126165321.ldpnudpiqyjsuv3v@linux.intel.com> References: <20171125193132.24321-1-jarkko.sakkinen@linux.intel.com> <20171125193132.24321-8-jarkko.sakkinen@linux.intel.com> <20171126154429.3stntmhj25otqmy5@linux.intel.com> <1511711405.20482.23.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1511711405.20482.23.camel@perches.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 26, 2017 at 07:50:05AM -0800, Joe Perches wrote: > On Sun, 2017-11-26 at 17:44 +0200, Jarkko Sakkinen wrote: > > On Sat, Nov 25, 2017 at 09:29:24PM +0200, Jarkko Sakkinen wrote: > > > + ptr = sgx_get_page(page->epc_page); > > > + ret = __edbgrd((unsigned long)ptr + offset, data); > ^^^^^^ > > > > + sgx_put_page(ptr); > > > + if (ret) { > > > + sgx_dbg(encl, "EDBGRD returned %d\n", ret); > > ~~~~~~ > > EDBGWR > > ? D'oh I meant to quote this part: ptr = sgx_get_page(page->epc_page); ret = __edbgwr((unsigned long)ptr + offset, data); sgx_put_page(ptr); if (ret) { sgx_dbg(encl, "EDBGRD returned %d\n", ret); return -EFAULT; } There's a typo in sgx_dbg(). /Jarkko