From: kbuild test robot <lkp@intel.com>
To: Jacob Chen <jacob-chen@iotwrt.com>
Cc: kbuild-all@01.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, mchehab@kernel.org,
linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
hans.verkuil@cisco.com, tfiga@chromium.org,
zhengsq@rock-chips.com, laurent.pinchart@ideasonboard.com,
zyc@rock-chips.com, eddie.cai.linux@gmail.com,
jeffy.chen@rock-chips.com, allon.huang@rock-chips.com,
devicetree@vger.kernel.org, heiko@sntech.de, robh+dt@kernel.org,
Jacob Chen <jacob2.chen@rock-chips.com>,
Jacob Chen <cc@rock-chips.com>
Subject: Re: [PATCH v2 03/11] media: rkisp1: add rockchip isp1 driver
Date: Mon, 27 Nov 2017 01:32:57 +0800 [thread overview]
Message-ID: <201711270005.B4X2tZ0p%fengguang.wu@intel.com> (raw)
In-Reply-To: <20171124023706.5702-4-jacob-chen@iotwrt.com>
[-- Attachment #1: Type: text/plain, Size: 7063 bytes --]
Hi Jacob,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20171124]
[cannot apply to rockchip/for-next v4.14]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Jacob-Chen/Rockchip-ISP1-Driver/20171126-224713
base: git://linuxtv.org/media_tree.git master
config: mips-allmodconfig (attached as .config)
compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=mips
All error/warnings (new ones prefixed by >>):
drivers/media//platform/rockchip/isp1/rkisp1.c: In function 'rkisp1_isp_sd_s_stream':
>> drivers/media//platform/rockchip/isp1/rkisp1.c:136:6: warning: 'isp_ctrl' may be used uninitialized in this function [-Wmaybe-uninitialized]
u32 isp_ctrl;
^~~~~~~~
>> drivers/media//platform/rockchip/isp1/rkisp1.c:209:2: warning: 'acq_mult' may be used uninitialized in this function [-Wmaybe-uninitialized]
writel(acq_mult * in_frm->width, base + CIF_ISP_ACQ_H_SIZE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media//platform/rockchip/isp1/rkisp1.c:139:6: note: 'acq_mult' was declared here
u32 acq_mult;
^~~~~~~~
--
drivers/media//platform/rockchip/isp1/dev.c: In function 'rkisp1_runtime_suspend':
drivers/media//platform/rockchip/isp1/dev.c:597:9: error: implicit declaration of function 'pinctrl_pm_select_sleep_state' [-Werror=implicit-function-declaration]
return pinctrl_pm_select_sleep_state(dev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media//platform/rockchip/isp1/dev.c: In function 'rkisp1_runtime_resume':
>> drivers/media//platform/rockchip/isp1/dev.c:605:8: error: implicit declaration of function 'pinctrl_pm_select_default_state'; did you mean 'irq_set_default_host'? [-Werror=implicit-function-declaration]
ret = pinctrl_pm_select_default_state(dev);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
irq_set_default_host
cc1: some warnings being treated as errors
--
>> drivers/media//platform/rockchip/isp1/isp_params.c:1350:3: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_enum_fmt_meta_out'; did you mean 'vidioc_enum_fmt_meta_cap'?
.vidioc_enum_fmt_meta_out = rkisp1_params_enum_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~~~~
vidioc_enum_fmt_meta_cap
drivers/media//platform/rockchip/isp1/isp_params.c:1350:30: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.vidioc_enum_fmt_meta_out = rkisp1_params_enum_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media//platform/rockchip/isp1/isp_params.c:1350:30: note: (near initialization for 'rkisp1_params_ioctl.vidioc_g_std')
>> drivers/media//platform/rockchip/isp1/isp_params.c:1351:3: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_g_fmt_meta_out'; did you mean 'vidioc_g_fmt_meta_cap'?
.vidioc_g_fmt_meta_out = rkisp1_params_g_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~
vidioc_g_fmt_meta_cap
drivers/media//platform/rockchip/isp1/isp_params.c:1351:27: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.vidioc_g_fmt_meta_out = rkisp1_params_g_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media//platform/rockchip/isp1/isp_params.c:1351:27: note: (near initialization for 'rkisp1_params_ioctl.vidioc_s_std')
>> drivers/media//platform/rockchip/isp1/isp_params.c:1352:3: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_s_fmt_meta_out'; did you mean 'vidioc_s_fmt_meta_cap'?
.vidioc_s_fmt_meta_out = rkisp1_params_g_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~
vidioc_s_fmt_meta_cap
drivers/media//platform/rockchip/isp1/isp_params.c:1352:27: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.vidioc_s_fmt_meta_out = rkisp1_params_g_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media//platform/rockchip/isp1/isp_params.c:1352:27: note: (near initialization for 'rkisp1_params_ioctl.vidioc_querystd')
>> drivers/media//platform/rockchip/isp1/isp_params.c:1353:3: error: 'const struct v4l2_ioctl_ops' has no member named 'vidioc_try_fmt_meta_out'; did you mean 'vidioc_try_fmt_meta_cap'?
.vidioc_try_fmt_meta_out = rkisp1_params_g_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~~~
vidioc_try_fmt_meta_cap
drivers/media//platform/rockchip/isp1/isp_params.c:1353:29: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.vidioc_try_fmt_meta_out = rkisp1_params_g_fmt_meta_out,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/media//platform/rockchip/isp1/isp_params.c:1353:29: note: (near initialization for 'rkisp1_params_ioctl.vidioc_enum_input')
drivers/media//platform/rockchip/isp1/isp_params.c: In function 'rkisp1_params_init_vb2_queue':
>> drivers/media//platform/rockchip/isp1/isp_params.c:1478:12: error: 'V4L2_BUF_TYPE_META_OUTPUT' undeclared (first use in this function); did you mean 'V4L2_BUF_TYPE_SDR_OUTPUT'?
q->type = V4L2_BUF_TYPE_META_OUTPUT;
^~~~~~~~~~~~~~~~~~~~~~~~~
V4L2_BUF_TYPE_SDR_OUTPUT
drivers/media//platform/rockchip/isp1/isp_params.c:1478:12: note: each undeclared identifier is reported only once for each function it appears in
drivers/media//platform/rockchip/isp1/isp_params.c: In function 'rkisp1_register_params_vdev':
>> drivers/media//platform/rockchip/isp1/isp_params.c:1523:43: error: 'V4L2_CAP_META_OUTPUT' undeclared (first use in this function); did you mean 'V4L2_CAP_RDS_OUTPUT'?
vdev->device_caps = V4L2_CAP_STREAMING | V4L2_CAP_META_OUTPUT;
^~~~~~~~~~~~~~~~~~~~
V4L2_CAP_RDS_OUTPUT
cc1: some warnings being treated as errors
vim +605 drivers/media//platform/rockchip/isp1/dev.c
591
592 static int __maybe_unused rkisp1_runtime_suspend(struct device *dev)
593 {
594 struct rkisp1_device *isp_dev = dev_get_drvdata(dev);
595
596 rkisp1_disable_sys_clk(isp_dev);
> 597 return pinctrl_pm_select_sleep_state(dev);
598 }
599
600 static int __maybe_unused rkisp1_runtime_resume(struct device *dev)
601 {
602 struct rkisp1_device *isp_dev = dev_get_drvdata(dev);
603 int ret;
604
> 605 ret = pinctrl_pm_select_default_state(dev);
606 if (ret < 0)
607 return ret;
608 rkisp1_enable_sys_clk(isp_dev);
609
610 return 0;
611 }
612
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 47597 bytes --]
next prev parent reply other threads:[~2017-11-26 17:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 2:36 [PATCH v2 00/11] Rockchip ISP1 Driver Jacob Chen
2017-11-24 2:36 ` [PATCH v2 01/11] media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer format Jacob Chen
2017-11-27 10:17 ` Hans Verkuil
2017-11-24 2:36 ` [PATCH v2 02/11] media: rkisp1: Add user space ABI definitions Jacob Chen
2017-11-27 10:26 ` Hans Verkuil
2017-11-28 5:58 ` Jacob Chen
2017-11-24 2:36 ` [PATCH v2 03/11] media: rkisp1: add rockchip isp1 driver Jacob Chen
2017-11-26 17:32 ` kbuild test robot [this message]
2017-11-27 11:40 ` Hans Verkuil
2017-11-30 2:51 ` Jacob Chen
2017-11-24 2:36 ` [PATCH v2 04/11] media: rkisp1: add Rockchip MIPI Synopsys DPHY driver Jacob Chen
2017-11-26 17:04 ` kbuild test robot
2017-11-26 18:13 ` kbuild test robot
2017-11-27 12:01 ` Hans Verkuil
2017-11-27 14:15 ` Jose Abreu
2017-11-29 8:38 ` Jacob Chen
2017-11-24 2:37 ` [PATCH v2 05/11] dt-bindings: Document the Rockchip ISP1 bindings Jacob Chen
2017-11-26 22:14 ` Rob Herring
2017-11-24 2:37 ` [PATCH v2 06/11] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings Jacob Chen
2017-11-26 22:16 ` Rob Herring
2017-11-24 2:37 ` [PATCH v2 07/11] ARM: dts: rockchip: add isp node for rk3288 Jacob Chen
2017-11-24 2:37 ` [PATCH v2 08/11] ARM: dts: rockchip: add rx0 mipi-phy " Jacob Chen
2017-11-24 2:37 ` [PATCH v2 09/11] arm64: dts: rockchip: add isp0 node for rk3399 Jacob Chen
2017-11-24 2:37 ` [PATCH v2 10/11] arm64: dts: rockchip: add rx0 mipi-phy " Jacob Chen
2017-11-24 2:37 ` [PATCH v2 11/11] MAINTAINERS: add entry for Rockchip ISP1 driver Jacob Chen
2017-11-24 6:15 ` [PATCH v2 00/11] Rockchip ISP1 Driver Jacob Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201711270005.B4X2tZ0p%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=allon.huang@rock-chips.com \
--cc=cc@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=jacob2.chen@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=kbuild-all@01.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=zhengsq@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).