From: Jiri Olsa <jolsa@redhat.com>
To: Milind Chabbi <chabbi.milind@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/core: Enable the bp only if the .disable field is 0.
Date: Mon, 27 Nov 2017 10:25:37 +0100 [thread overview]
Message-ID: <20171127092438.GA23704@krava> (raw)
In-Reply-To: <CAMmz+YnSSn3t=qSjfMX5H5Mp6QuTePkuLMjV7FO7at8z4TXu1Q@mail.gmail.com>
On Sun, Nov 26, 2017 at 10:50:27PM -0800, Milind Chabbi wrote:
> On Sun, Nov 26, 2017 at 10:43 PM, Milind Chabbi <chabbi.milind@gmail.com> wrote:
> > Signed-off-by: Milind Chabbi <chabbi.milind@gmail.com>
> > ---
> > kernel/events/core.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index 35747a58ffb4..1b8eae85e9de 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -2659,7 +2659,8 @@ static int perf_event_modify_breakpoint(struct perf_event *bp,
> > return err;
> > }
> >
> > - _perf_event_enable(bp);
> > + if (!attr->disabled)
> > + _perf_event_enable(bp);
> > return 0;
> > }
> >
> > --
> > 2.14.1
> >
>
> Hi Jirka,
> Thanks for your changes for proper accounting of the bp.
> This additional change is needed so that we do not enable the bp if
> the user has not asked to enable it.
> I did the testing for ioctl and it continues to show the significant
> speedups that I had originally seen.
right, I'll merge this in and post
thanks,
jirka
prev parent reply other threads:[~2017-11-27 9:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAMmz+Y=Py0dw63tuww+Oa4rWi_Hghhs3DHmNX=Tf1Yt_JH4O+Q@mail.gmail.com>
2017-11-06 9:23 ` [PATCH] perf/core: fast breakpoint modification via _IOC_MODIFY_BREAKPOINT Jiri Olsa
[not found] ` <CAMmz+YkB955Na6wOMmgqZX_TxqsBh86FiLi8EXmOrg1vwm-fGA@mail.gmail.com>
2017-11-08 14:15 ` Jiri Olsa
2017-11-08 15:02 ` Milind Chabbi
2017-11-08 15:12 ` Jiri Olsa
2017-11-08 15:51 ` Milind Chabbi
2017-11-08 15:57 ` Jiri Olsa
2017-11-08 16:59 ` Milind Chabbi
2017-11-09 7:52 ` Jiri Olsa
2017-11-09 13:12 ` Jiri Olsa
2017-11-09 18:59 ` Milind Chabbi
2017-11-12 19:09 ` Milind Chabbi
2017-11-13 7:46 ` Jiri Olsa
2017-11-13 8:02 ` Milind Chabbi
2017-11-26 19:31 ` Jiri Olsa
2017-11-27 6:43 ` [PATCH] perf/core: Enable the bp only if the .disable field is 0 Milind Chabbi
2017-11-27 6:50 ` Milind Chabbi
2017-11-27 9:25 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127092438.GA23704@krava \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=chabbi.milind@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).