From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdK0Ku1 (ORCPT ); Mon, 27 Nov 2017 05:50:27 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:43576 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbdK0Kt0 (ORCPT ); Mon, 27 Nov 2017 05:49:26 -0500 X-Google-Smtp-Source: AGs4zMaojQnnH06NtsC40tMRzq6VbLFJkMTgt76+I5RNmAVNbCObvTrhmG4oph9C8UAvZl6lEV1XGQ== From: Bartosz Golaszewski To: Linus Walleij , Bamvor Jian Zhang Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 16/18] gpio: mockup: modify the return value check for devm_irq_sim_init() Date: Mon, 27 Nov 2017 11:48:52 +0100 Message-Id: <20171127104854.333-17-brgl@bgdev.pl> X-Mailer: git-send-email 2.15.0 In-Reply-To: <20171127104854.333-1-brgl@bgdev.pl> References: <20171127104854.333-1-brgl@bgdev.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As discussed with Marc Zyngier: irq_sim_init() and its devres variant should return the base of the allocated interrupt range on success rather than 0. This will be modified later - first, change the way users handle the return value of these routines. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-mockup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c index cbc823e43151..0abb53038ba8 100644 --- a/drivers/gpio/gpio-mockup.c +++ b/drivers/gpio/gpio-mockup.c @@ -297,7 +297,7 @@ static int gpio_mockup_probe(struct platform_device *pdev) } rv = devm_irq_sim_init(dev, &chip->irqsim, gc->ngpio); - if (rv) + if (rv < 0) return rv; rv = devm_gpiochip_add_data(dev, &chip->gc, chip); -- 2.15.0