From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751660AbdK1IbV (ORCPT <rfc822;w@1wt.eu>);
        Tue, 28 Nov 2017 03:31:21 -0500
Received: from Galois.linutronix.de ([146.0.238.70]:59916 "EHLO
        Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751355AbdK1IbU (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 28 Nov 2017 03:31:20 -0500
Date: Tue, 28 Nov 2017 09:31:14 +0100
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Clark Williams <williams@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@kernel.org>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        John Kacur <jkacur@redhat.com>, Scott Wood <swood@redhat.com>,
        Mike Galbraith <efault@gmx.de>
Subject: Re: [PATCH RT] fix IPI balancing for 4.14-rt
Message-ID: <20171128083114.GA1540@linutronix.de>
References: <20171006140504.48dc32c1@gandalf.local.home>
 <20171121091425.7577dc02@tagon>
 <20171121102436.3e25655f@gandalf.local.home>
 <20171123172538.GB32454@linutronix.de>
 <20171127172521.184b9a46@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20171127172521.184b9a46@gandalf.local.home>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017-11-27 17:25:21 [-0500], Steven Rostedt wrote:
> On Thu, 23 Nov 2017 18:25:39 +0100
> Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> 
>  
> > I cherry-picked commit 4bdced5c9a29 ("sched/rt: Simplify the IPI based
> > RT balancing logic") and while refreshing the queue I noticed that the
> > irq_work struct moved and added the fix below into the original patch
> > where the IRQ_WORK_HARD_IRQ flag was added.
> 
> Perhaps you should keep it as a separate patch. 4bdced5c9a29 is now in
> mainline. The next time you port to mainline, you may drop this fix,
> and cause the scheduling IPI to run in threaded context (which would be
> bad).
> 
> Having it as a separate patch, would remind us that it would need to be
> added to mainline in the future.

That patch in v4.14 rt-devel RT git tree has it as one commit. The patch
in RT queue has the IRQ_WORK_HARD_IRQ added in the patch where that flag
was introduced. For reference:
https://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git/tree/patches/irqwork-push_most_work_into_softirq_context.patch?h=linux-4.14.y-rt-patches&id=657d8cd9f93891840fb1cd1666a8e590d19e72ba#n144

> Feel free to add to that that patch:
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> -- Steve

Sebastian