linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, Dan Carpenter <dan.carpenter@oracle.com>,
	Kalle Valo <kvalo@codeaurora.org>,
	Sasha Levin <alexander.levin@verizon.com>
Subject: [PATCH 4.9 108/138] adm80211: return an error if adm8211_alloc_rings() fails
Date: Tue, 28 Nov 2017 11:23:29 +0100	[thread overview]
Message-ID: <20171128100553.256423378@linuxfoundation.org> (raw)
In-Reply-To: <20171128100544.706504901@linuxfoundation.org>

4.9-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Dan Carpenter <dan.carpenter@oracle.com>


[ Upstream commit c705a6b3aa7804d7bc6660183f51e510c61dc807 ]

We accidentally return success when adm8211_alloc_rings() fails but we
should preserve the error code.

Fixes: cc0b88cf5ecf ("[PATCH] Add adm8211 802.11b wireless driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/net/wireless/admtek/adm8211.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/net/wireless/admtek/adm8211.c
+++ b/drivers/net/wireless/admtek/adm8211.c
@@ -1843,7 +1843,8 @@ static int adm8211_probe(struct pci_dev
 	priv->rx_ring_size = rx_ring_size;
 	priv->tx_ring_size = tx_ring_size;
 
-	if (adm8211_alloc_rings(dev)) {
+	err = adm8211_alloc_rings(dev);
+	if (err) {
 		printk(KERN_ERR "%s (adm8211): Cannot allocate TX/RX ring\n",
 		       pci_name(pdev));
 		goto err_iounmap;

  parent reply	other threads:[~2017-11-28 10:40 UTC|newest]

Thread overview: 144+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-28 10:21 [PATCH 4.9 000/138] 4.9.66-stable review Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 002/138] s390/runtime instrumention: fix possible memory corruption Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 003/138] s390/disassembler: add missing end marker for e7 table Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 004/138] s390/disassembler: increase show_code buffer size Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 005/138] ACPI / EC: Fix regression related to triggering source of EC event handling Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 006/138] x86/mm: fix use-after-free of vma during userfaultfd fault Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 007/138] ipv6: only call ip6_route_dev_notify() once for NETDEV_UNREGISTER Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 008/138] vsock: use new wait API for vsock_stream_sendmsg() Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 009/138] sched: Make resched_cpu() unconditional Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 010/138] lib/mpi: call cond_resched() from mpi_powm() loop Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 011/138] x86/decoder: Add new TEST instruction pattern Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 012/138] x86/entry/64: Add missing irqflags tracing to native_load_gs_index() Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 013/138] arm64: Implement arch-specific pte_access_permitted() Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 014/138] ARM: 8722/1: mm: make STRICT_KERNEL_RWX effective for LPAE Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 015/138] ARM: 8721/1: mm: dump: check hardware RO bit " Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 016/138] MIPS: ralink: Fix MT7628 pinmux Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 017/138] MIPS: ralink: Fix typo in mt7628 pinmux function Greg Kroah-Hartman
2017-11-28 10:21 ` [PATCH 4.9 018/138] PCI: Set Cavium ACS capability quirk flags to assert RR/CR/SV/UF Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 019/138] ALSA: hda: Add Raven PCI ID Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 020/138] dm bufio: fix integer overflow when limiting maximum cache size Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 021/138] dm: allocate struct mapped_device with kvzalloc Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 022/138] MIPS: pci: Remove KERN_WARN instance inside the mt7620 driver Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 023/138] dm: fix race between dm_get_from_kobject() and __dm_destroy() Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 024/138] MIPS: Fix odd fp register warnings with MIPS64r2 Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 025/138] MIPS: dts: remove bogus bcm96358nb4ser.dtb from dtb-y entry Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 026/138] MIPS: Fix an n32 core file generation regset support regression Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 028/138] rt2x00usb: mark device removed when get ENOENT usb error Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 029/138] autofs: dont fail mount for transient error Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 030/138] nilfs2: fix race condition that causes file system corruption Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 031/138] eCryptfs: use after free in ecryptfs_release_messaging() Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 032/138] libceph: dont WARN() if user tries to add invalid key Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 033/138] bcache: check ca->alloc_thread initialized before wake up it Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 034/138] isofs: fix timestamps beyond 2027 Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 035/138] NFS: Fix typo in nomigration mount option Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 036/138] nfs: Fix ugly referral attributes Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 037/138] NFS: Avoid RCU usage in tracepoints Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 038/138] nfsd: deal with revoked delegations appropriately Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 039/138] rtlwifi: rtl8192ee: Fix memory leak when loading firmware Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 040/138] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 041/138] ata: fixes kernel crash while tracing ata_eh_link_autopsy event Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 042/138] ext4: fix interaction between i_size, fallocate, and delalloc after a crash Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 043/138] ALSA: pcm: update tstamp only if audio_tstamp changed Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 044/138] ALSA: usb-audio: Add sanity checks to FE parser Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 045/138] ALSA: usb-audio: Fix potential out-of-bound access at parsing SU Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 046/138] ALSA: usb-audio: Add sanity checks in v2 clock parsers Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 047/138] ALSA: timer: Remove kernel warning at compat ioctl error paths Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 048/138] ALSA: hda: Fix too short HDMI/DP chmap reporting Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 049/138] ALSA: hda/realtek - Fix ALC700 family no sound issue Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 050/138] fix a page leak in vhost_scsi_iov_to_sgl() error recovery Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 051/138] fs/9p: Compare qid.path in v9fs_test_inode Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 052/138] iscsi-target: Fix non-immediate TMR reference leak Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 053/138] target: Fix QUEUE_FULL + SCSI task attribute handling Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 054/138] mtd: nand: omap2: Fix subpage write Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 055/138] mtd: nand: Fix writing mtdoops to nand flash Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 056/138] mtd: nand: mtk: fix infinite ECC decode IRQ issue Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 057/138] p54: dont unregister leds when they are not initialized Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 058/138] block: Fix a race between blk_cleanup_queue() and timeout handling Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 059/138] irqchip/gic-v3: Fix ppi-partitions lookup Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 060/138] lockd: double unregister of inetaddr notifiers Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 061/138] KVM: nVMX: set IDTR and GDTR limits when loading L1 host state Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 063/138] SUNRPC: Fix tracepoint storage issues with svc_recv and svc_rqst_status Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 064/138] clk: ti: dra7-atl-clock: fix child-node lookups Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 065/138] libnvdimm, pfn: make resource attribute only readable by root Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 066/138] libnvdimm, namespace: fix label initialization to use valid seq numbers Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 067/138] libnvdimm, namespace: make resource attribute only readable by root Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 068/138] IB/srpt: Do not accept invalid initiator port names Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 069/138] IB/srp: Avoid that a cable pull can trigger a kernel crash Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 070/138] NFC: fix device-allocation error return Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 071/138] i40e: Use smp_rmb rather than read_barrier_depends Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 072/138] igb: " Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 073/138] igbvf: " Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 074/138] ixgbevf: " Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 075/138] i40evf: " Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 076/138] fm10k: " Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 077/138] ixgbe: Fix skb list corruption on Power systems Greg Kroah-Hartman
2017-11-28 10:22 ` [PATCH 4.9 078/138] parisc: Fix validity check of pointer size argument in new CAS implementation Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 079/138] powerpc/signal: Properly handle return value from uprobe_deny_signal() Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 080/138] media: Dont do DMA on stack for firmware upload in the AS102 driver Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 081/138] media: rc: check for integer overflow Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 082/138] [media] cx231xx-cards: fix NULL-deref on missing association descriptor Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 083/138] media: v4l2-ctrl: Fix flags field on Control events Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 084/138] sched/rt: Simplify the IPI based RT balancing logic Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 085/138] fscrypt: lock mutex before checking for bounce page pool Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 086/138] net/9p: Switch to wait_event_killable() Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 087/138] PM / OPP: Add missing of_node_put(np) Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 089/138] e1000e: Fix error path in link detection Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 090/138] e1000e: Fix return value test Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 091/138] e1000e: Separate signaling for link check/link up Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 092/138] e1000e: Avoid receiver overrun interrupt bursts Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 093/138] RDS: make message size limit compliant with spec Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 094/138] RDS: RDMA: return appropriate error on rdma map failures Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 095/138] RDS: RDMA: fix the ib_map_mr_sg_zbva() argument Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 096/138] PCI: Apply _HPX settings only to relevant devices Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 097/138] drm/sun4i: Fix a return value in case of error Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 098/138] clk: sunxi-ng: A31: Fix spdif clock register Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 099/138] clk: sunxi-ng: fix PLL_CPUX adjusting on A33 Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 100/138] dmaengine: zx: set DMA_CYCLIC cap_mask bit Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 101/138] fscrypt: use ENOKEY when file cannot be created w/o key Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 102/138] fscrypt: use ENOTDIR when setting encryption policy on nondirectory Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 103/138] net: Allow IP_MULTICAST_IF to set index to L3 slave Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 104/138] net: 3com: typhoon: typhoon_init_one: make return values more specific Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 105/138] net: 3com: typhoon: typhoon_init_one: fix incorrect return values Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 106/138] drm/armada: Fix compile fail Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 107/138] rt2800: set minimum MPDU and PSDU lengths to sane values Greg Kroah-Hartman
2017-11-28 10:23 ` Greg Kroah-Hartman [this message]
2017-11-28 10:23 ` [PATCH 4.9 109/138] mwifiex: sdio: fix use after free issue for save_adapter Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 110/138] ath10k: fix incorrect txpower set by P2P_DEVICE interface Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 111/138] ath10k: ignore configuring the incorrect board_id Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 112/138] ath10k: fix potential memory leak in ath10k_wmi_tlv_op_pull_fw_stats() Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 113/138] pinctrl: sirf: atlas7: Add missing of_node_put() Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 114/138] bnxt_en: Set default completion ring for async events Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 115/138] ath10k: set CTS protection VDEV param only if VDEV is up Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 116/138] ALSA: hda - Apply ALC269_FIXUP_NO_SHUTUP on HDA_FIXUP_ACT_PROBE Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 117/138] gpio: mockup: dynamically allocate memory for chip name Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 118/138] drm: Apply range restriction after color adjustment when allocation Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 119/138] clk: qcom: ipq4019: Add all the frequencies for apss cpu Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 120/138] drm/mediatek: dont use drm_put_dev Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 121/138] mac80211: Remove invalid flag operations in mesh TSF synchronization Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 122/138] mac80211: Suppress NEW_PEER_CANDIDATE event if no room Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 123/138] adm80211: add checks for dma mapping errors Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 124/138] iio: light: fix improper return value Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 125/138] staging: iio: cdc: " Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 126/138] spi: SPI_FSL_DSPI should depend on HAS_DMA Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 127/138] netfilter: nft_queue: use raw_smp_processor_id() Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 128/138] netfilter: nf_tables: fix oob access Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 129/138] ASoC: rsnd: dont double free kctrl Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 130/138] crypto: marvell - Copy IVDIG before launching partial DMA ahash requests Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 131/138] btrfs: return the actual error value from from btrfs_uuid_tree_iterate Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 132/138] ASoC: wm_adsp: Dont overrun firmware file buffer when reading region data Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 133/138] s390/kbuild: enable modversions for symbols exported from asm Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 134/138] [media] cec: when canceling a message, dont overwrite old status info Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 135/138] [media] cec: CEC_MSG_GIVE_FEATURES should abort for CEC version < 2 Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 136/138] [media] cec: update log_addr[] before finishing configuration Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 137/138] nvmet: fix KATO offset in Set Features Greg Kroah-Hartman
2017-11-28 10:23 ` [PATCH 4.9 138/138] xen: xenbus driver must not accept invalid transaction ids Greg Kroah-Hartman
     [not found] ` <20171128100551.657694618@linuxfoundation.org>
2017-11-28 10:45   ` [PATCH 4.9 088/138] Revert "drm/i915: Do not rely on wm preservation for ILK watermarks" Rainer Fiebig
2017-11-28 17:37 ` [Lkft-triage] [PATCH 4.9 000/138] 4.9.66-stable review Naresh Kamboju
2017-11-29  8:07   ` Greg Kroah-Hartman
2017-11-29 10:07     ` Mark Brown
2017-11-29 10:35       ` Greg Kroah-Hartman
2017-11-29 10:44         ` Mark Brown
2017-11-29 14:52         ` Dan Rue
2017-11-28 19:47 ` Shuah Khan
2017-11-28 21:51 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128100553.256423378@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=alexander.levin@verizon.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).