From: Steven Rostedt <rostedt@goodmis.org>
To: "Vladislav Valtchev (VMware)" <vladislav.valtchev@gmail.com>
Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com
Subject: Re: [PATCH 08/11] trace-cmd: Making start,extract,stream,profile separate funcs
Date: Tue, 28 Nov 2017 12:14:50 -0500 [thread overview]
Message-ID: <20171128121450.32db5781@gandalf.local.home> (raw)
In-Reply-To: <20171123163335.19078-9-vladislav.valtchev@gmail.com>
On Thu, 23 Nov 2017 18:33:32 +0200
"Vladislav Valtchev (VMware)" <vladislav.valtchev@gmail.com> wrote:
> +static void init_common_record_context(struct common_record_context
*ctx,
> + enum trace_cmd curr_cmd)
> +{
> + memset(ctx, 0, sizeof(*ctx));
> + ctx->instance = &top_instance;
> + ctx->curr_cmd = curr_cmd;
> + init_instance(ctx->instance);
> + cpu_count = count_cpus();
> +}
>
> +void trace_start(int argc, char **argv)
> +{
> + struct common_record_context ctx;
> +
> + init_common_record_context(&ctx, CMD_start);
> + parse_record_options(argc, argv, &ctx);
> + record_trace(argc, argv, &ctx);
> + exit(0);
> +}
> +
> +void trace_extract(int argc, char **argv)
> +{
> + struct common_record_context ctx;
> +
> + init_common_record_context(&ctx, CMD_extract);
> + parse_record_options(argc, argv, &ctx);
> + record_trace(argc, argv, &ctx);
> + exit(0);
> +}
> +
> +void trace_stream(int argc, char **argv)
> +{
> + struct common_record_context ctx;
> +
> + init_common_record_context(&ctx, CMD_stream);
> + parse_record_options(argc, argv, &ctx);
> + record_trace(argc, argv, &ctx);
> + exit(0);
> +}
> +
> +void trace_profile(int argc, char **argv)
> +{
> + struct common_record_context ctx;
> +
> + init_common_record_context(&ctx, CMD_profile);
> +
> + handle_init = trace_init_profile;
> + ctx.events = 1;
Why setting events = 1?
> +
> + parse_record_options(argc, argv, &ctx);
> +
> + /*
> + * If no instances were set, then enable profiling on the top instance.
> + */
> + if (!buffer_instances)
> + top_instance.profile = 1;
> +
> + record_trace(argc, argv, &ctx);
> + trace_profile_int();
> exit(0);
> }
>
> @@ -4934,24 +4980,8 @@ void trace_record(int argc, char **argv)
> {
> struct common_record_context ctx;
>
> - init_common_record_context(&ctx);
> - init_instance(ctx.instance);
> -
> - if (strcmp(argv[1], "record") == 0)
> - ctx.curr_cmd = CMD_record;
> - else if (strcmp(argv[1], "start") == 0)
> - ctx.curr_cmd = CMD_start;
> - else if (strcmp(argv[1], "extract") == 0)
> - ctx.curr_cmd = CMD_extract;
> - else if (strcmp(argv[1], "stream") == 0)
> - ctx.curr_cmd = CMD_stream;
> - else if (strcmp(argv[1], "profile") == 0) {
> - ctx.curr_cmd = CMD_profile;
> - handle_init = trace_init_profile;
> - ctx.events = 1;
> - } else
> - usage(argv);
> -
> + init_common_record_context(&ctx, CMD_record);
> parse_record_options(argc, argv, &ctx);
As everything is doing both init_common_record_context() and
parse_record_options() why not just move the
init_common_record_context() into parse_record_options(). If you need
to do something special (like set events = 1 for profile) have that
done in parse_record_options() if the cmd is CMD_record. Yes, you need
to pass the CMD_* to parse_record_options() in this case.
-- Steve
> record_trace(argc, argv, &ctx);
> + exit(0);
> }
next prev parent reply other threads:[~2017-11-28 17:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 16:33 [PATCH 00/11] trace-cmd: Refactoring trace_record() Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 01/11] trace-cmd: Extract trace_stop() from trace_record() Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 02/11] trace-cmd: Extract trace_restart() " Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 03/11] trace-cmd: Extract trace_reset() " Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 04/11] trace-cmd: Extract parse_record_options() " Vladislav Valtchev (VMware)
2017-11-28 16:48 ` Steven Rostedt
2017-11-28 18:17 ` Vladislav Valtchev
2017-11-28 18:30 ` Steven Rostedt
2017-11-28 18:57 ` Vladislav Valtchev
2017-11-28 19:15 ` Steven Rostedt
2017-11-29 14:53 ` Steven Rostedt
2017-11-29 15:18 ` Vladislav Valtchev
2017-11-23 16:33 ` [PATCH 05/11] trace-cmd: Rename trace_profile() to trace_profile_int() Vladislav Valtchev (VMware)
2017-11-28 17:05 ` Steven Rostedt
2017-11-28 19:00 ` Vladislav Valtchev
2017-11-23 16:33 ` [PATCH 06/11] trace-cmd: Replacing cmd flags w/ a trace_cmd enum Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 07/11] trace-cmd: Extracting record_trace() Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 08/11] trace-cmd: Making start,extract,stream,profile separate funcs Vladislav Valtchev (VMware)
2017-11-28 17:14 ` Steven Rostedt [this message]
2017-11-28 18:34 ` Vladislav Valtchev
2017-11-28 19:35 ` Steven Rostedt
2017-11-29 10:03 ` Vladislav Valtchev
2017-11-29 12:48 ` Steven Rostedt
2017-11-23 16:33 ` [PATCH 09/11] trace-cmd: Consolidate ARRAY_SIZE() in trace-cmd.h Vladislav Valtchev (VMware)
2017-11-28 17:16 ` Steven Rostedt
2017-11-23 16:33 ` [PATCH 10/11] trace-cmd: Making the "die" functions noreturn Vladislav Valtchev (VMware)
2017-11-23 16:33 ` [PATCH 11/11] trace-cmd: Introducing get_trace_cmd_type() Vladislav Valtchev (VMware)
2017-11-28 17:17 ` Steven Rostedt
2017-11-28 18:32 ` Steven Rostedt
2017-11-28 19:04 ` Vladislav Valtchev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128121450.32db5781@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vladislav.valtchev@gmail.com \
--cc=y.karadz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).