From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbdK1Sa1 (ORCPT ); Tue, 28 Nov 2017 13:30:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:49410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751767AbdK1Sa0 (ORCPT ); Tue, 28 Nov 2017 13:30:26 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC131218D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Tue, 28 Nov 2017 13:30:24 -0500 From: Steven Rostedt To: Vladislav Valtchev Cc: linux-kernel@vger.kernel.org, y.karadz@gmail.com Subject: Re: [PATCH 04/11] trace-cmd: Extract parse_record_options() from trace_record() Message-ID: <20171128133024.4f3b06e4@gandalf.local.home> In-Reply-To: <1511893066.1754.8.camel@gmail.com> References: <20171123163335.19078-1-vladislav.valtchev@gmail.com> <20171123163335.19078-5-vladislav.valtchev@gmail.com> <20171128114822.0f80ed1e@gandalf.local.home> <1511893066.1754.8.camel@gmail.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 28 Nov 2017 20:17:46 +0200 Vladislav Valtchev wrote: > Since that code was profile-specific, I put it in trace_profile(), > without 'if' statements, clearly. This is all about balancing. You were able to remove one if statement, but required two function calls by all others. -- Steve