From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753102AbdK1N4R (ORCPT ); Tue, 28 Nov 2017 08:56:17 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:37091 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752073AbdK1N4Q (ORCPT ); Tue, 28 Nov 2017 08:56:16 -0500 Date: Tue, 28 Nov 2017 14:56:10 +0100 From: Andrew Lunn To: Antoine Tenart Cc: rmk@armlinux.org.uk, f.fainelli@gmail.com, davem@davemloft.net, Yan Markman , gregory.clement@free-electrons.com, thomas.petazzoni@free-electrons.com, miquel.raynal@free-electrons.com, nadavh@marvell.com, mw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: phylink: fix link state on phy-connect Message-ID: <20171128135610.GD20797@lunn.ch> References: <20171128132932.27196-1-antoine.tenart@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128132932.27196-1-antoine.tenart@free-electrons.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + /* On _disconnect, the phy state machine and phylink resolve > + * are stopped before executing full gracefull down/reset state. > + * The further _connect starts with incorrect init state. Let's set > + * init values here. > + */ > + pl->phy_state.link = false; > + pl->link_config.pause = MLO_PAUSE_AN; > + pl->link_config.speed = SPEED_UNKNOWN; > + pl->link_config.duplex = DUPLEX_UNKNOWN; Hi Antoine Looks sensible. My only comment would be, maybe it makes sense to reduce the duplication by adding a little helper which is called here, and in phylink_create()? Andrew