From: Russell King <rmk@armlinux.org.uk>
To: Antoine Tenart <antoine.tenart@free-electrons.com>
Cc: andrew@lunn.ch, f.fainelli@gmail.com, davem@davemloft.net,
Yan Markman <ymarkman@marvell.com>,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
mw@semihalf.com, stefanc@marvell.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phylink: fix link state on phy-connect
Date: Tue, 28 Nov 2017 15:56:11 +0000 [thread overview]
Message-ID: <20171128155611.GA8358@flint.armlinux.org.uk> (raw)
In-Reply-To: <20171128155317.GA7974@flint.armlinux.org.uk>
Oh, and lastly, please send patches to linux@armlinux.org.uk or the
address I use in the sign-offs - sending them to rmk@armlinux.org.uk
is for personal non-Linux mail only, and has resulted in _all_ of
these messages ending up in my spam folder.
Thanks.
On Tue, Nov 28, 2017 at 03:53:17PM +0000, Russell King wrote:
> On Tue, Nov 28, 2017 at 02:29:32PM +0100, Antoine Tenart wrote:
> > From: Yan Markman <ymarkman@marvell.com>
>
> Hi, thanks for the patch.
>
> > When calling successively _connect, _disconnect and _connect again, if
> > the link configuration changed whilst being down from the phylink
> > perspective, the last _connect would stay in an incorrect old speed.
> > Fixes this by setting the link configuration parameters to an unknown
> > value when calling phylink_bringup_phy.
>
> Under what circumstances does this occur?
>
> >
> > Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> > Signed-off-by: Yan Markman <ymarkman@marvell.com>
> > [Antoine: commit message]
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> > ---
> > drivers/net/phy/phylink.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> > index e3bbc70372d3..c2cec3eef67d 100644
> > --- a/drivers/net/phy/phylink.c
> > +++ b/drivers/net/phy/phylink.c
> > @@ -621,6 +621,16 @@ static int phylink_bringup_phy(struct phylink *pl, struct phy_device *phy)
> > if (ret)
> > return ret;
> >
> > + /* On _disconnect, the phy state machine and phylink resolve
> > + * are stopped before executing full gracefull down/reset state.
> > + * The further _connect starts with incorrect init state. Let's set
> > + * init values here.
> > + */
> > + pl->phy_state.link = false;
> > + pl->link_config.pause = MLO_PAUSE_AN;
> > + pl->link_config.speed = SPEED_UNKNOWN;
> > + pl->link_config.duplex = DUPLEX_UNKNOWN;
>
> It would be much better to clean up the phy_state in
> phylink_disconnect_phy() and trigger a resolve, rather than doing that
> each time a PHY is connected - the link should be taken down when the
> PHY is removed.
>
> However, I'd like to know under what circumstances this is happening,
> since, if you're hotplugging a PHY you should be doing that via SFP
> which has additional link up/down handling. What board is this with?
>
> Also note that there's a number of patches in my "phy" branch that
> I'm intending to send as a result of working with Florian over the
> last few weeks. There's several people working fairly independently
> in this area and having everyone send patches independently of each
> other could get painful to manage.
>
> I'm intending to send patches once I know that net-next is open.
>
> --
> Russell King
> ARM architecture Linux Kernel maintainer
--
Russell King
ARM architecture Linux Kernel maintainer
next prev parent reply other threads:[~2017-11-28 15:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 13:29 [PATCH net] net: phylink: fix link state on phy-connect Antoine Tenart
2017-11-28 13:56 ` Andrew Lunn
2017-11-28 14:10 ` Antoine Tenart
2017-11-28 15:53 ` Russell King
2017-11-28 15:56 ` Russell King [this message]
2017-11-29 7:22 ` Antoine Tenart
2017-11-29 19:33 ` [EXT] " Yan Markman
2017-11-29 19:59 ` Russell King - ARM Linux
2017-11-29 21:06 ` [EXT] " Yan Markman
2017-11-29 21:20 ` Russell King - ARM Linux
2017-11-30 8:51 ` Yan Markman
2017-11-30 10:10 ` Russell King - ARM Linux
2017-11-30 13:28 ` Russell King - ARM Linux
2017-12-01 17:07 ` Grygorii Strashko
2017-12-01 17:24 ` Russell King - ARM Linux
2017-12-01 17:36 ` Florian Fainelli
2017-12-01 17:47 ` Russell King - ARM Linux
2017-12-02 11:08 ` Yan Markman
2017-12-02 14:58 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128155611.GA8358@flint.armlinux.org.uk \
--to=rmk@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@free-electrons.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ymarkman@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).