From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754242AbdK1UVK (ORCPT ); Tue, 28 Nov 2017 15:21:10 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43005 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754216AbdK1UVH (ORCPT ); Tue, 28 Nov 2017 15:21:07 -0500 Date: Tue, 28 Nov 2017 21:21:05 +0100 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io, linux-sunxi@googlegroups.com Subject: Re: [PATCH 02/17] drm/sun4i: Start using layer id in DE2 driver Message-ID: <20171128202105.rrwldhr4e4n3x4ya@flea.home> References: <20171127205750.19277-1-jernej.skrabec@siol.net> <20171127205750.19277-3-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="34y6mf5zcick5wta" Content-Disposition: inline In-Reply-To: <20171127205750.19277-3-jernej.skrabec@siol.net> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --34y6mf5zcick5wta Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 27, 2017 at 09:57:35PM +0100, Jernej Skrabec wrote: > Till now, plane selection was hardcoded to first overlay in first UI > channel. >=20 > It turns out that overlays don't fit well in current DRM design, because > they can't be blended together or scaled independetly when they are set > to same channel. >=20 > Beause of that, always use only first overlay in each channel. This > simplifies things, since layer parameter can be then used as channel > selection. >=20 > Signed-off-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/sun8i_layer.c | 2 +- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 31 +++++++++++-------------------- > 2 files changed, 12 insertions(+), 21 deletions(-) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun8i_layer.c b/drivers/gpu/drm/sun4i/= sun8i_layer.c > index 23810ff72684..5b2d45a9db8a 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_layer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_layer.c > @@ -126,7 +126,7 @@ struct drm_plane **sun8i_layers_init(struct drm_devic= e *drm, > return ERR_CAST(layer); > }; > =20 > - layer->id =3D i; > + layer->id =3D mixer->cfg->vi_num + i; > planes[i] =3D &layer->plane; > }; So we had pretty much the same intent here :) But I really feel we should model the hardware and have both the channel and layer IDs. Obviously, at (that patch) moment, we don't have support for multiple layers per channel, but eventually we should really model the hardware as much as possible. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --34y6mf5zcick5wta Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlodxQIACgkQ0rTAlCFN r3S5VA//fgm9h3nNHDHJRjwvQY+yfq/m21oGF0eYCuqHQaY6hfAgjWERs2B6edP8 6H2yPRpPBiIVZArQcDHTHY/vNQdSdctqi/HOaW+js43uEeP3BVgI2XsPr6yi7+qv BcArSyKSuod/FpL4y20BwaasKtwjHfQqIROrrpJS4Miip3hbJHgx6AWE18yBx6oj Og/pTiLxFtuvxlz912tFj/RLWzUvOV85I4ludnCZ5uiAWAEjMrx5uoPHYK/7N3M5 TeCUjurp1Emo/JP7cqY29ku4FsnV1eWKLc/6Hpu+Y4iv7tT14uHSaYSFux8e337L 5v5GTaCNleWWGkS7hBLNIrM9BpvAVzpgPeckVBma+v3CMuXICyr5bkOUM0MX043c NQzokYeZIkyg+jBVHubkGHSshcGY6TxV+WlKYkI/tUW2bRw6Z0Q3GPp5IelUmsvN RcMjWuPegmgjQaVg1QDByLprjvssD1MoDW7AKEWrA6EwKlZN971EK9AtHXekVp6l 6o7rDaku3VBa/rP51TADC0FIH7+PtWaGKO5jCDyLNvAqcONl1zBVWyQlbNYYWafI XQ1Z3lH0OSi/5q5+ByNAa9WJ5MJ6jbMIsq3gg9u8DHy3vD0cTdA4Ah/iTG36mim8 okuq//6aMBa3Ff/PusWXqQhXdlPH5nKcnX6Zi6C5QlIcTvtDwRY= =0jxM -----END PGP SIGNATURE----- --34y6mf5zcick5wta--