From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754273AbdK1U0t (ORCPT ); Tue, 28 Nov 2017 15:26:49 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43277 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753254AbdK1U0r (ORCPT ); Tue, 28 Nov 2017 15:26:47 -0500 Date: Tue, 28 Nov 2017 21:26:45 +0100 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io, linux-sunxi@googlegroups.com Subject: Re: [PATCH 05/17] drm/sun4i: Reorder some code in DE2 Message-ID: <20171128202645.gyf42cdlwebfu66l@flea.home> References: <20171127205750.19277-1-jernej.skrabec@siol.net> <20171127205750.19277-6-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bqcxckd6xbit42tt" Content-Disposition: inline In-Reply-To: <20171127205750.19277-6-jernej.skrabec@siol.net> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bqcxckd6xbit42tt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Nov 27, 2017 at 09:57:38PM +0100, Jernej Skrabec wrote: > While DE2 driver works, parts of the code are not in optimal place. Reord= er > it so it will be easier to support multiple planes. >=20 > This commit doesn't do any functional change besides removing two not > very useful debug messages. >=20 > Signed-off-by: Jernej Skrabec So I have the same feeling here that it could be split into several patches, but you should at least explain why and how that code is more optimal than it used to. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --bqcxckd6xbit42tt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlodxoEACgkQ0rTAlCFN r3T9hA//TkpKZ7naTKpo5cMP211bXrKEFx5WmTQLWbxAt3Um2pw+wZvx/rvUeZRx oVqjCuCNsJRWujMUFWMdxeb8LN/FJi+AN80oxiP85NaQtLcaSN8mH7C6v6Zc/6qo a/yrt3uiMctuFdZqH72BiWDSQC7Sc3UUDSDOEI+9nlGcT7Hbo09uIeE2BWdp/nH5 8WupoEzHNbG+suYHL4+TPQFa+zxi/ZNGhvr/0aNYzmi9nmvqdXA8axxNGTVqsIz/ A1YihNdKy5ebA3JanqG1k1/HCUvvYVaETBCSbtsRFlv3WYLfGSflppjtlxu851BJ ci/6nVaXznZQ2L/o3QvbYNmXetIbuTIHXb+3rStEsFX/hOm1+csGRUqAhmJz0mOs pRSpABTE96tdGrZi6HPKB8SFlwtyLatyuPM5s0buUXgdVxlYeb5kLjNNJpV7pF9Z cuzz9R7D3sgN7mYUcycRYBhkzcil6XkmTyrL2B25dvh2mC1TMHxnpSaI1Rz0fYXp jtd7Y4ARx3vBegaFlh+M6t3+GxaXMYKwb5t6wU58FQpANzeFavMhpTzSY5HQDQtE 8Jy/pfGi+grOODJJ480IesV1jqUz2+3h1mmsGka9NX07IY8Po7VJh8ykL96wAqdv hUNNIuMNw8gZVC5gTQt4o9Cc6bmgNchdvCJkwtu0HcUCSuIFYtM= =JVUh -----END PGP SIGNATURE----- --bqcxckd6xbit42tt--