From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754193AbdK1UcC (ORCPT ); Tue, 28 Nov 2017 15:32:02 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43443 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbdK1Ub7 (ORCPT ); Tue, 28 Nov 2017 15:31:59 -0500 Date: Tue, 28 Nov 2017 21:31:57 +0100 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io, linux-sunxi@googlegroups.com Subject: Re: [PATCH 10/17] drm/sun4i: Add scaler configuration to DE2 mixers Message-ID: <20171128203157.id6mflespftuavbq@flea.home> References: <20171127205750.19277-1-jernej.skrabec@siol.net> <20171127205750.19277-11-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zfh7f77pal5pcod6" Content-Disposition: inline In-Reply-To: <20171127205750.19277-11-jernej.skrabec@siol.net> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zfh7f77pal5pcod6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Nov 27, 2017 at 09:57:43PM +0100, Jernej Skrabec wrote: > No all SoCs support scaling on all channels. For example, V3s support > scaling only on VI channels. Because of that, add additional > configuration bitmask which tells which channel support scaler. >=20 > Signed-off-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/sun8i_mixer.c | 1 + > drivers/gpu/drm/sun4i/sun8i_mixer.h | 1 + > 2 files changed, 2 insertions(+) >=20 > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/= sun8i_mixer.c > index dc97351be973..291dd8806444 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c > @@ -576,6 +576,7 @@ static int sun8i_mixer_remove(struct platform_device = *pdev) > static const struct sun8i_mixer_cfg sun8i_v3s_mixer_cfg =3D { > .vi_num =3D 2, > .ui_num =3D 1, > + .scaler_mask =3D 0x3, > }; > =20 > static const struct of_device_id sun8i_mixer_of_table[] =3D { > diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h b/drivers/gpu/drm/sun4i/= sun8i_mixer.h > index 572ef184a21a..ad5aef5846ae 100644 > --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h > +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h > @@ -139,6 +139,7 @@ > struct sun8i_mixer_cfg { > int vi_num; > int ui_num; > + int scaler_mask; Can you add a comment there to explain what the scaler_mask is ? (ideally in kerneldoc) Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --zfh7f77pal5pcod6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlodx7kACgkQ0rTAlCFN r3Q59g/9FcTcgaBR3JRX6XYislW7QbeQH8tJA9E0546ZhomoRyB7SZwTuIxwFtm3 982QdNGOs/14nHe1xQvnBT8BVT3zI3x3iTjLUTkUo3OLB3jjN8aStO8sprb0+S9Y AiNcnIyLBnS2KLkscECjMv64cFKz5tXT+VLm2pDmfIKMNH8yYOEceYFw88U9wPVN /bOTrGabhrHHgRJUlZOmWHScfkvHQA7YBUNyeYgpoQVIKIuw2JZ3+LjAfw5eNR5Y HXwZzCHOdNyczKg1TRhVOgNRtDO0Z1pJogRdqKA460Y0AyUbhZIt5vlAENcwgxaV +yd7kHUKNKRCoc2fA7Bb3qKMd7tUhzvmyr9DcfedUTvTNdWlO58oOodGYiV1ZQnw metX+R9xHkJQrNEe2OwtGCDbsRVbnXPswwCMy5PgEBY5yrxi8lNKUROu8Xhzvq+l pP07+M5etqI6dPmEiQxOLYi5lfAeJ9MzatRFx8mRwpwQ/GPA15JaZPMlBsqcFAtd /8yYODRMe2VrF0Of4ZyTCGGlk2Q+9ljzC9P9VNf1qeKo25AXugkQfgzbM6Fuf919 76bvlJi6IEhk5Hi4ceLnUQtMZ5H1G4AhPjHuSCV6Fw8jxmLEvJNSCrVyXw73tVrp ToH/kn59/GO8QCsVHYw4C4w99L8HzFQw9uzHXAZMmotB/tc5wi8= =SNGV -----END PGP SIGNATURE----- --zfh7f77pal5pcod6--