From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932261AbdK1UkY (ORCPT ); Tue, 28 Nov 2017 15:40:24 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:43711 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753818AbdK1UkV (ORCPT ); Tue, 28 Nov 2017 15:40:21 -0500 Date: Tue, 28 Nov 2017 21:40:19 +0100 From: Maxime Ripard To: Jernej Skrabec Cc: wens@csie.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io, linux-sunxi@googlegroups.com Subject: Re: [PATCH 09/17] drm/sun4i: Add scaler library for DE2 Message-ID: <20171128204019.tzyfn45gnwxe5uao@flea.home> References: <20171127205750.19277-1-jernej.skrabec@siol.net> <20171127205750.19277-10-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jrx42gdgauzowaer" Content-Disposition: inline In-Reply-To: <20171127205750.19277-10-jernej.skrabec@siol.net> User-Agent: NeoMutt/20171027 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jrx42gdgauzowaer Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Nov 27, 2017 at 09:57:42PM +0100, Jernej Skrabec wrote: > Scaler library currently supports scaling only RGB planes on VI planes. >=20 > Coefficients and algorithm which ones to select are taken from BSP driver. >=20 > Signed-off-by: Jernej Skrabec > --- > drivers/gpu/drm/sun4i/Makefile | 2 +- > drivers/gpu/drm/sun4i/sun8i_scaler.c | 667 +++++++++++++++++++++++++++++= ++++++ > drivers/gpu/drm/sun4i/sun8i_scaler.h | 78 ++++ > 3 files changed, 746 insertions(+), 1 deletion(-) > create mode 100644 drivers/gpu/drm/sun4i/sun8i_scaler.c > create mode 100644 drivers/gpu/drm/sun4i/sun8i_scaler.h >=20 > diff --git a/drivers/gpu/drm/sun4i/Makefile b/drivers/gpu/drm/sun4i/Makef= ile > index 0c2f8c7facae..70df480792f9 100644 > --- a/drivers/gpu/drm/sun4i/Makefile > +++ b/drivers/gpu/drm/sun4i/Makefile > @@ -9,7 +9,7 @@ sun4i-drm-hdmi-y +=3D sun4i_hdmi_enc.o > sun4i-drm-hdmi-y +=3D sun4i_hdmi_i2c.o > sun4i-drm-hdmi-y +=3D sun4i_hdmi_tmds_clk.o > =20 > -sun8i-mixer-y +=3D sun8i_mixer.o sun8i_layer.o > +sun8i-mixer-y +=3D sun8i_mixer.o sun8i_layer.o sun8i_scaler.o > =20 > sun4i-tcon-y +=3D sun4i_crtc.o > sun4i-tcon-y +=3D sun4i_dotclock.o > diff --git a/drivers/gpu/drm/sun4i/sun8i_scaler.c b/drivers/gpu/drm/sun4i= /sun8i_scaler.c > new file mode 100644 > index 000000000000..23525beceaa2 > --- /dev/null > +++ b/drivers/gpu/drm/sun4i/sun8i_scaler.c > @@ -0,0 +1,667 @@ > +/* > + * Copyright (C) 2017 Jernej Skrabec > + * > + * Coefficients are taken from BSP driver, which is: > + * Copyright (C) 2014-2015 Allwinner Saying from which BSP you got them would be great for future reference It looks good otherwise. I kind of hate those big array of undocumented data, but there's nothing you can do about it either, so we'll have to deal with it :) Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --jrx42gdgauzowaer Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0VqZU19dR2zEVaqr0rTAlCFNr3QFAlodya8ACgkQ0rTAlCFN r3TcZA//amwPkqhWLY8EuLjuSVranoYC9hX+Dodz139hC+QKONYNVDJB8QSg19/a ZPe7H58IjevWdNRr1pbH6f/17CTjDODeJ0ZkM+5NMIo/qAASl0P8zDqMpEsZPCWc egY79qixGiik61nRmpHL+I23m+D5dyF/pRzg3zlVSNVZTvInpPaeOEbYa84VNAK7 SSKsNpEZJEzYTaZ7odAFQYA5GFz4wUd47W+zQCkwPfD04g7B6HC8Ma9PxbmYKAeK yVVn0CJrPLyTw8SdlbSyerIcc5Tmv0mIk4BOXM7KtAkqGN58vaBJIddyTcq2+ROt GPRbWNMo5Rv3jZToYauq8XW6q9jLw2wkx5fHaSOujQY4EThSN3XbGCfMs8uBqGAm ZDB1Ukg9vnAaqDrE2Gz2CTk/6n914T/xKyUmqb+hqNQ6z9UhPSW7bpxq3T1y2dSP iZAweK8kDLmtDOcpJPCnipewgLXOHF/breWFGDKl40gNaD8QEeHonXvy5X1rlsZH tFNqg1bGjbXEXHF4+bqoBL0HfMTcBXrAmn7P4oUvhqLJb2jLRwHarde+z0yTOYeA eToivJ4u3Lt8e44ReG2LpjzIjeEmmBA6KUkxN0kAYsXgrZXpAMsxBVwS8jpjhsvE fzagwkO1UwGA6Hruu7BYG4qrJGngI04ABk1n27ItOQxpLTurnWM= =yDlV -----END PGP SIGNATURE----- --jrx42gdgauzowaer--