From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752361AbdK1VF4 (ORCPT ); Tue, 28 Nov 2017 16:05:56 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:35924 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752269AbdK1VFw (ORCPT ); Tue, 28 Nov 2017 16:05:52 -0500 Date: Tue, 28 Nov 2017 13:05:51 -0800 From: Christoph Hellwig To: Jarkko Sakkinen Cc: Christoph Hellwig , platform-driver-x86@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, Alexander Viro , "open list:FILESYSTEMS (VFS and infrastructure)" Subject: Re: [PATCH v6 09/11] fs/pipe.c: export create_pipe_files() and replace_fd() Message-ID: <20171128210551.GA12431@infradead.org> References: <20171125193132.24321-1-jarkko.sakkinen@linux.intel.com> <20171125193132.24321-10-jarkko.sakkinen@linux.intel.com> <20171128143504.GA22918@infradead.org> <20171128204220.j7ipouoyhsbvm7zk@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171128204220.j7ipouoyhsbvm7zk@linux.intel.com> User-Agent: Mutt/1.9.1 (2017-09-22) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2017 at 10:42:20PM +0200, Jarkko Sakkinen wrote: > On Tue, Nov 28, 2017 at 06:35:04AM -0800, Christoph Hellwig wrote: > > Repeated NAK - any interface that deals with raw file descriptor table > > entries has absolutely no business in a driver. > > > > Please fix your API already. > > Does it make a differnece if the code is moved to arch/x86, which could > potentially happen (see Darren's and tglx's comments on v5)? Then the > need for export will be gone. Yes. You still shall not play nasty games with file descriptors.