From: David Miller <davem@davemloft.net>
To: willy@infradead.org
Cc: kubakici@wp.pl, mawilcox@microsoft.com, chrism@mellanox.com,
jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com,
daniel@iogearbox.net, ebiggers@google.com, laijs@cn.fujitsu.com,
tj@kernel.org, aquannie@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 11/17] cls_bpf: Convert to use idr_alloc_u32
Date: Wed, 29 Nov 2017 11:35:49 -0500 (EST) [thread overview]
Message-ID: <20171129.113549.1990396476364963247.davem@davemloft.net> (raw)
In-Reply-To: <20171129162916.GA18402@bombadil.infradead.org>
From: Matthew Wilcox <willy@infradead.org>
Date: Wed, 29 Nov 2017 08:29:16 -0800
> On Tue, Nov 28, 2017 at 05:08:40PM -0800, Jakub Kicinski wrote:
>> On Tue, 28 Nov 2017 13:33:06 -0800, Matthew Wilcox wrote:
>> > + ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
>> > + INT_MAX, GFP_KERNEL);
>> > + } else if (!oldprog) {
>> > + ret = idr_alloc_u32(&head->handle_idr, prog, &handle,
>> > + handle, GFP_KERNEL);
>>
>> nit: in many places you seem to not align the second line with opening
>> parenthesis. Is that intentional?
>
> It's more that I don't care. I press 'enter', which indents the arguments
> by a certain amount, then press the 'tab' key until it looks aesthetically
> pleasing.
>
>> FWIW there may be a small merge conflict with net on cls_bpf in patch
>> 5, some of the code has been removed.
>
> Thanks. Dave, do you want to take the IDR patches through your tree to
> save conflict resolution?
Sure, after you fix the indentation problems Jakub pointed out please
resubmit them separately to netdev.
next prev parent reply other threads:[~2017-11-29 16:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 21:32 [PATCH 00/17] IDR patches for 4.15 Matthew Wilcox
2017-11-28 21:32 ` [PATCH 01/17] idr: Fix build Matthew Wilcox
2017-11-28 21:32 ` [PATCH 02/17] radix tree test suite: Remove ARRAY_SIZE Matthew Wilcox
2017-11-28 21:32 ` [PATCH 03/17] idr test suite: Fix ida_test_random() Matthew Wilcox
2017-11-28 21:32 ` [PATCH 04/17] IDR test suite: Check handling negative end correctly Matthew Wilcox
2017-11-28 21:33 ` [PATCH 05/17] idr: Delete idr_remove_ext function Matthew Wilcox
2017-11-28 21:33 ` [PATCH 06/17] idr: Delete idr_replace_ext function Matthew Wilcox
2017-11-28 21:33 ` [PATCH 07/17] idr: Delete idr_find_ext function Matthew Wilcox
2017-11-28 21:33 ` [PATCH 08/17] idr: Add idr_alloc_u32 helper Matthew Wilcox
2017-11-28 21:33 ` [PATCH 09/17] net sched actions: Convert to use idr_alloc_u32 Matthew Wilcox
2017-11-28 21:33 ` [PATCH 10/17] cls_basic: " Matthew Wilcox
2017-11-28 21:33 ` [PATCH 11/17] cls_bpf: " Matthew Wilcox
2017-11-29 1:08 ` Jakub Kicinski
2017-11-29 16:29 ` Matthew Wilcox
2017-11-29 16:35 ` David Miller [this message]
2017-11-28 21:33 ` [PATCH 12/17] cls_flower: Convert to idr_alloc_u32 Matthew Wilcox
2017-11-28 21:33 ` [PATCH 13/17] cls_u32: Reinstate cyclic allocation Matthew Wilcox
2017-11-28 21:33 ` [PATCH 14/17] cls_u32: Convert to idr_alloc_u32 Matthew Wilcox
2017-11-28 21:33 ` [PATCH 15/17] idr: Rename idr_alloc_ext to idr_alloc_ul Matthew Wilcox
2017-11-28 21:33 ` [PATCH 16/17] idr: Rename idr_for_each_entry_ext Matthew Wilcox
2017-11-28 21:33 ` [PATCH 17/17] idr: Warn if old iterators see large IDs Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129.113549.1990396476364963247.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aquannie@gmail.com \
--cc=chrism@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=ebiggers@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=kubakici@wp.pl \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=tj@kernel.org \
--cc=willy@infradead.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).