From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932149AbdK2JkN (ORCPT ); Wed, 29 Nov 2017 04:40:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:43044 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbdK2JkM (ORCPT ); Wed, 29 Nov 2017 04:40:12 -0500 Date: Wed, 29 Nov 2017 10:40:10 +0100 From: Michal Hocko To: linux-mm@kvack.org Cc: Mike Kravetz , Naoya Horiguchi , LKML Subject: Re: [PATCH RFC 2/2] mm, hugetlb: do not rely on overcommit limit during migration Message-ID: <20171129094010.ycf23oibkdq6cggq@dhcp22.suse.cz> References: <20171128101907.jtjthykeuefxu7gl@dhcp22.suse.cz> <20171128141211.11117-1-mhocko@kernel.org> <20171128141211.11117-3-mhocko@kernel.org> <20171129092234.eluli2gl7gotj35x@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171129092234.eluli2gl7gotj35x@dhcp22.suse.cz> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 29-11-17 10:22:34, Michal Hocko wrote: > What about this on top. I haven't tested this yet though. > --- We will need to drop surplus_huge_pages_node handling from the free path obviously as well diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 1be43563e226..756833f9ef8b 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -1312,8 +1312,6 @@ void free_huge_page(struct page *page) list_del(&page->lru); ClearPageHugeTemporary(page); update_and_free_page(h, page); - if (h->surplus_huge_pages_node[nid]) - h->surplus_huge_pages_node[nid]--; } else if (h->surplus_huge_pages_node[nid]) { /* remove the page from active list */ list_del(&page->lru); -- Michal Hocko SUSE Labs