From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754812AbdK2NwH (ORCPT ); Wed, 29 Nov 2017 08:52:07 -0500 Received: from mga02.intel.com ([134.134.136.20]:19694 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbdK2NwF (ORCPT ); Wed, 29 Nov 2017 08:52:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,473,1505804400"; d="scan'208";a="10990168" Date: Wed, 29 Nov 2017 19:25:36 +0530 From: Vinod Koul To: "Rafael J. Wysocki" Cc: Sinan Kaya , dmaengine@vger.kernel.org, timur@codeaurora.org, linux-arm-msm , linux-arm-kernel@lists.infradead.org, robin.murphy@arm.com, linux-kernel@vger.kernel.org, "linux-acpi@vger.kernel.org" Subject: Re: [PATCH V3 2/4] ACPI / bus: introduce acpi_device_get_match_data() function Message-ID: <20171129135536.GD32417@localhost> References: <1510281175-27173-1-git-send-email-okaya@codeaurora.org> <1510281175-27173-2-git-send-email-okaya@codeaurora.org> <31ef1ea5-ddb6-1a24-980b-7986627cfeca@codeaurora.org> <1605519.pfaIp4IsxJ@aspire.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1605519.pfaIp4IsxJ@aspire.rjw.lan> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 12, 2017 at 01:14:12AM +0100, Rafael J. Wysocki wrote: > On Friday, November 10, 2017 3:35:41 AM CET Sinan Kaya wrote: > > +linux-acpi@vger.kernel.org, +Rafael > > Thanks! > > > On 11/9/2017 9:32 PM, Sinan Kaya wrote: > > > OF has of_device_get_match_data() function to extract driver specific data > > > structure. Add a similar function for ACPI. > > > > > > Signed-off-by: Sinan Kaya > > > --- > > > drivers/acpi/bus.c | 12 ++++++++++++ > > > include/linux/acpi.h | 6 ++++++ > > > 2 files changed, 18 insertions(+) > > > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > > index 4d0979e..da29c10 100644 > > > --- a/drivers/acpi/bus.c > > > +++ b/drivers/acpi/bus.c > > > @@ -785,6 +785,18 @@ const struct acpi_device_id *acpi_match_device(const struct acpi_device_id *ids, > > > } > > > EXPORT_SYMBOL_GPL(acpi_match_device); > > > > > > +void *acpi_device_get_match_data(const struct device *dev) > > > +{ > > > + const struct acpi_device_id *match; > > > + > > > + match = acpi_match_device(dev->driver->acpi_match_table, dev); > > > + if (!match) > > > + return NULL; > > > + > > > + return (void *)match->driver_data; > > > +} > > > +EXPORT_SYMBOL_GPL(acpi_device_get_match_data); > > While I understand that the name follows the OF convention, I have some > doubts on whether it is the best one. Perhpas acpi_get_match_data() ? -- ~Vinod