From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751745AbdK2F4R (ORCPT ); Wed, 29 Nov 2017 00:56:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:35240 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbdK2F4Q (ORCPT ); Wed, 29 Nov 2017 00:56:16 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4DAB2192A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=mhiramat@kernel.org Date: Wed, 29 Nov 2017 14:56:12 +0900 From: Masami Hiramatsu To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mhiramat@kernel.org, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 09/12] perf, tools: Downgrade register mapping message to warning Message-Id: <20171129145612.54e80c4646bee281679ceba6@kernel.org> In-Reply-To: <20171128002321.2878-10-andi@firstfloor.org> References: <20171128002321.2878-1-andi@firstfloor.org> <20171128002321.2878-10-andi@firstfloor.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Nov 2017 16:23:18 -0800 Andi Kleen wrote: > From: Andi Kleen > > When tracing floating point code it's quite possible that perf > doesn't recognize the register number. Downgrade the warning > for unknown registers to a debug message. Hmm, but without this message, user will just see ENOTSUP error. I'm considering to introduce storage of error string for probe-finder so that user can choose to show it or not. Thank you, > > Signed-off-by: Andi Kleen > --- > tools/perf/util/probe-finder.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c > index 137b2fe71838..5fe6466254f9 100644 > --- a/tools/perf/util/probe-finder.c > +++ b/tools/perf/util/probe-finder.c > @@ -272,8 +272,8 @@ static int convert_variable_location(Dwarf_Die *vr_die, Dwarf_Addr addr, > > regs = get_dwarf_regstr(regn, machine); > if (!regs) { > - /* This should be a bug in DWARF or this tool */ > - pr_warning("Mapping for the register number %u " > + /* This can happen with floating point */ > + pr_debug("Mapping for the register number %u " > "missing on this architecture.\n", regn); > return -ENOTSUP; > } > -- > 2.13.6 > -- Masami Hiramatsu