From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Govinda Tatti <govinda.tatti@oracle.com>,
Juergen Gross <jgross@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute
Date: Wed, 29 Nov 2017 14:26:30 -0500 [thread overview]
Message-ID: <20171129192630.GS31092@char.us.oracle.com> (raw)
In-Reply-To: <5A1EF1040200007800193425@prv-mh.provo.novell.com>
On Wed, Nov 29, 2017 at 09:40:20AM -0700, Jan Beulich wrote:
> >>> On 29.11.17 at 17:29, <konrad.wilk@oracle.com> wrote:
> > On Wed, Nov 29, 2017 at 08:35:33AM -0700, Jan Beulich wrote:
> >> >>> On 29.11.17 at 16:08, <govinda.tatti@oracle.com> wrote:
> >> > On 11/9/2017 2:28 AM, Jan Beulich wrote:
> >> >>>>> On 08.11.17 at 16:44, <govinda.tatti@oracle.com> wrote:
> >> >>> On 11/7/2017 8:40 AM, Jan Beulich wrote:
> >> >>>>>>> On 06.11.17 at 18:48, <Govinda.Tatti@Oracle.COM> wrote:
> >> >>>>> --- a/Documentation/ABI/testing/sysfs-driver-pciback
> >> >>>>> +++ b/Documentation/ABI/testing/sysfs-driver-pciback
> >> >>>>> @@ -11,3 +11,15 @@ Description:
> >> >>>>> #echo 00:19.0-E0:2:FF >
> > /sys/bus/pci/drivers/pciback/quirks
> >> >>>>> will allow the guest to read and write to the
> > configuration
> >> >>>>> register 0x0E.
> >> >>>>> +
> >> >>>>> +What: /sys/bus/pci/drivers/pciback/do_flr
> >> >>>>> +Date: Nov 2017
> >> >>>>> +KernelVersion: 4.15
> >> >>>>> +Contact: xen-devel@lists.xenproject.org
> >> >>>>> +Description:
> >> >>>>> + An option to perform a slot or bus reset when a PCI device
> >> >>>>> + is owned by Xen PCI backend. Writing a string of DDDD:BB:DD.F
> >> >>>>> + will cause the pciback driver to perform a slot or bus reset
> >> >>>>> + if the device supports it. It also checks to make sure that
> >> >>>>> + all of the devices under the bridge are owned by Xen PCI
> >> >>>>> + backend.
> >> >>>> Why do you name this "do_flr" when you don't even try FLR, but
> >> >>>> go to slot or then bus reset right away.
> >> >>> Yes, I agree but xen toolstack has already been modified to
> >> >>> consume"do_flr" attribute. Hence, we are using the
> >> >>> function that matches with sysfs attribute.
> >> >> That's not a valid reason imo: Right now the driver doesn't expose
> >> >> such an attribute, so if the tool stack was trying to use it, it would
> >> >> not do what is intended at present anyway (i.e. the code could at
> >> >> best be called dead).
> >> > Sure, we can consider renaming "do_flr" attribute to "pci reset" or "bus
> >> > reset".
> >> > Please let me knowyour preference.
> >>
> >> Well, that's more a question to Konrad as the maintainer.
> >> Personally I'd prefer just "reset", as "pci" is redundant and "bus"
> >
> > Can't do 'reset'.
>
> Why?
B/c I forgot that this attribute is not per device, but on the module sub-directory:
/sys/bus/pci/drivers/pciback/do_flr
It can be indeed called 'reset'.
>
> >> doesn't cover the slot variant.
> >
> > 'bus_reset' sounds lovely?
>
> Lovely sounding or not, it may end up misleading, and even more so
> if - like asked for - FLR would be tried first.
Fair enough. Reset should work then.
next prev parent reply other threads:[~2017-11-29 19:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 17:48 [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute Govinda Tatti
2017-11-07 11:21 ` [Xen-devel] " Roger Pau Monné
2017-11-08 15:00 ` Govinda Tatti
2017-11-08 15:09 ` Juergen Gross
2017-11-08 15:34 ` Govinda Tatti
2017-11-07 14:40 ` Jan Beulich
2017-11-08 15:44 ` Govinda Tatti
2017-11-08 17:38 ` Pasi Kärkkäinen
2017-11-08 23:26 ` Govinda Tatti
2017-11-09 8:28 ` Jan Beulich
2017-11-29 15:08 ` Govinda Tatti
2017-11-29 15:35 ` Jan Beulich
2017-11-29 16:29 ` Konrad Rzeszutek Wilk
2017-11-29 16:40 ` Jan Beulich
2017-11-29 19:26 ` Konrad Rzeszutek Wilk [this message]
2017-11-29 19:44 ` Govinda Tatti
2017-11-30 8:29 ` Jan Beulich
2017-11-30 13:55 ` Govinda Tatti
2017-11-29 17:25 ` Govinda Tatti
2017-11-29 18:05 ` Pasi Kärkkäinen
2017-11-29 19:51 ` Govinda Tatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129192630.GS31092@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=govinda.tatti@oracle.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).