From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbdK2VUz (ORCPT ); Wed, 29 Nov 2017 16:20:55 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:44360 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbdK2VUy (ORCPT ); Wed, 29 Nov 2017 16:20:54 -0500 Date: Wed, 29 Nov 2017 21:20:32 +0000 From: Russell King - ARM Linux To: Yan Markman Cc: Antoine Tenart , "andrew@lunn.ch" , "f.fainelli@gmail.com" , "davem@davemloft.net" , "gregory.clement@free-electrons.com" , "thomas.petazzoni@free-electrons.com" , "miquel.raynal@free-electrons.com" , Nadav Haklai , "mw@semihalf.com" , Stefan Chulski , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH net] net: phylink: fix link state on phy-connect Message-ID: <20171129212032.GI8356@n2100.armlinux.org.uk> References: <20171128132932.27196-1-antoine.tenart@free-electrons.com> <20171128155317.GA7974@flint.armlinux.org.uk> <20171128155611.GA8358@flint.armlinux.org.uk> <20448667430e434aad5bb8cd1b082611@IL-EXCH01.marvell.com> <20171129195911.GG8356@n2100.armlinux.org.uk> <21ec97be76d54a6c8a80fd5b56d35678@IL-EXCH01.marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21ec97be76d54a6c8a80fd5b56d35678@IL-EXCH01.marvell.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 09:06:56PM +0000, Yan Markman wrote: > The attached p21 patch doesn't change anything. > But another one from the mail-text is good > void phylink_disconnect_phy(struct phylink *pl) > + pl->phy_state.link = false; > > There still (not for my MRVL-PP2) problem: > It is expected that on ifconfig-down the callback > pl->ops->mac_link_down(ndev, pl->link_an_mode); > would be called, but it isn't Are you calling phylink_stop() or are you just calling phylink_disconnect() ? You must call phylink_stop() prior to phylink_disconnect(). This probably explains why the p21 patch did nothing. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up According to speedtest.net: 8.21Mbps down 510kbps up