From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbdK3F4X (ORCPT ); Thu, 30 Nov 2017 00:56:23 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:26728 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdK3F4W (ORCPT ); Thu, 30 Nov 2017 00:56:22 -0500 Date: Thu, 30 Nov 2017 08:55:44 +0300 From: Dan Carpenter To: Joshua Abraham Cc: arnaud.patard@rtp-net.org, kstewart@linuxfoundation.org, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, pombredanne@nexb.com, tglx@linutronix.de Subject: Re: [PATCH] staging: xgifb: remove unused macro XGIPART3 Message-ID: <20171130055544.zumzsypzwzssozts@mwanda> References: <20171130025348.GA11487@josharch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171130025348.GA11487@josharch> User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 29, 2017 at 09:53:48PM -0500, Joshua Abraham wrote: > Signed-off-by: Joshua Abraham > > This patch removes the unused macro XGIPART3. > The Signed-off-by line goes after the changelog. > --- > drivers/staging/xgifb/XGI_main.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/xgifb/XGI_main.h b/drivers/staging/xgifb/XGI_main.h > index a3af1cbbf8ee..5f55d0a39bc1 100644 > --- a/drivers/staging/xgifb/XGI_main.h > +++ b/drivers/staging/xgifb/XGI_main.h > @@ -25,7 +25,6 @@ MODULE_DEVICE_TABLE(pci, xgifb_pci_table); > #define XGIDACD (xgifb_info->dev_info.P3c9) > #define XGIPART1 (xgifb_info->dev_info.Part1Port) > #define XGIPART2 (xgifb_info->dev_info.Part2Port) > -#define XGIPART3 (xgifb_info->dev_info.Part3Port) That define isn't hurting anyone. > #define XGIPART4 (xgifb_info->dev_info.Part4Port) > #define XGIPART5 (xgifb_info->dev_info.Part5Port) Actually these should all be deleted because they mean you have to have a xgifb_info variable and they hurt readability by hiding stuff behind a define. It would be better to remove them all than to just remove one from the middle. That's a more complicated patch, but it's a useful patch. regards, dan carpenter